Re: [PATCH v8 6/9] ARM: dts: add AM33XX EDMA support

Matt Porter
2013-03-06T14:01:30Z

On Wed, Mar 06, 2013 at 04:19:58AM +0000, Kumar, Anil wrote:
> Hi,
>
> On Wed, Mar 06, 2013 at 02:23:12, Porter, Matt wrote:
> > Adds AM33XX EDMA support to the am33xx.dtsi as documented in
> > Documentation/devicetree/bindings/dma/ti-edma.txt
> >
> > Signed-off-by: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
> > ---
> > arch/arm/boot/dts/am33xx.dtsi | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index 0957645..aaf44122 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -87,6 +87,26 @@
> > reg = <0x48200000 0x1000>;
> > };
> >
> > + edma: edma@49000000 {
> > + compatible = "ti,edma3";
> > + ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2";
> > + reg = <0x49000000 0x10000>,
> > + <0x44e10f90 0x10>;
> > + interrupt-parent = <&intc>;
>
> Is it really need of "interrupt-parent = <&intc>" here ?
> as this property is already with root node.
> I am taking reference of 3.9-rc1

You're correct. It's inherited from the parent node so I'll drop it out.
I also noted that the cpsw node has this wrong so I'll send a patch to
address that separately.

-Matt

------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
endpoint security space. For insight on selecting the right partner to
tackle endpoint security challenges, access the full report.