From: Adrian Hunter <adrian.hunter@intel.com>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Namjae Jeon <linkinjeon@gmail.com>,
Sergey Yanovich <ynvich@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH 1/2] Revert "mmc: core: wait while adding MMC host to ensure root mounts successfully"
Date: Thu, 4 Apr 2013 16:41:05 +0300 [thread overview]
Message-ID: <1365082866-28404-2-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1365082866-28404-1-git-send-email-adrian.hunter@intel.com>
This reverts commit 3500ed90b26a9935b943b5e2e4cd3226600d6b58.
The reverted patch caused a significant performance regression when
booting with the root file system on eMMC.
Before the patch:
[ 1.625623] VFS: Mounted root (ext4 filesystem) readonly on device 179:2.
After the patch:
[ 1.935851] VFS: Mounted root (ext4 filesystem) readonly on device 179:2.
That was an addition of 310 ms which is a 19% performance degradation.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
drivers/mmc/core/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index ad7decc..3bf1c46 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2418,7 +2418,6 @@ void mmc_start_host(struct mmc_host *host)
host->rescan_disable = 0;
mmc_power_up(host);
mmc_detect_change(host, 0);
- mmc_flush_scheduled_work();
}
void mmc_stop_host(struct mmc_host *host)
--
1.7.11.7
next prev parent reply other threads:[~2013-04-04 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 13:41 [PATCH 0/2] sdhci-acpi initialization performance regression Adrian Hunter
2013-04-04 13:41 ` Adrian Hunter [this message]
2013-04-04 13:52 ` [PATCH 1/2] Revert "mmc: core: wait while adding MMC host to ensure root mounts successfully" Sergey Yanovich
2013-04-04 13:41 ` [PATCH 2/2] mmc: core: fix performance regression initializing MMC host controllers Adrian Hunter
2013-04-04 21:02 ` Ulf Hansson
2013-04-05 7:26 ` Adrian Hunter
2013-04-05 7:40 ` [PATCH V2 2/2] mmc: core: fix performance regression initializing MMC, " Adrian Hunter
2013-04-05 9:49 ` [PATCH 2/2] mmc: core: fix performance regression initializing MMC " Ulf Hansson
2013-04-05 13:30 ` Adrian Hunter
2013-04-05 13:31 ` [PATCH V3 " Adrian Hunter
2013-04-08 9:41 ` Ulf Hansson
2013-04-08 10:49 ` [PATCH V4 " Adrian Hunter
2013-04-12 18:09 ` [PATCH 0/2] sdhci-acpi initialization performance regression Chris Ball
2013-04-15 6:47 ` Adrian Hunter
2013-04-15 15:42 ` Chris Ball
2013-04-17 5:55 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365082866-28404-2-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=linkinjeon@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=ynvich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox