From: Namjae Jeon <linkinjeon@gmail.com>
To: dwmw2@infradead.org, axboe@kernel.dk, shli@kernel.org,
Paul.Clements@steeleye.com, npiggin@kernel.dk, neilb@suse.de,
cjb@laptop.org, adrian.hunter@intel.com
Cc: linux-mtd@lists.infradead.org, nbd-general@lists.sourceforge.net,
linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, Namjae Jeon <linkinjeon@gmail.com>,
Namjae Jeon <namjae.jeon@samsung.com>,
Vivek Trivedi <t.vivek@samsung.com>
Subject: [PATCH 1/8] block: fix max discard sectors limit
Date: Sat, 13 Apr 2013 22:38:13 +0900 [thread overview]
Message-ID: <1365860293-21227-1-git-send-email-linkinjeon@gmail.com> (raw)
From: Namjae Jeon <namjae.jeon@samsung.com>
https://lkml.org/lkml/2013/4/1/292
As per above discussion, it has been oberved that few drivers are
setting q->limits.max_discard_sectors to more than (UINT_MAX >> 9)
If multiple discard requests get merged, merged discard request's
size exceeds 4GB, there is possibility that merged discard request's
__data_len field may overflow.
This patch fixes this issue.
Also, adding BLK_DEF_MAX_DISCARD_SECTORS macro to use it instead
of UINT_MAX >> 9
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
---
block/blk-settings.c | 3 ++-
include/linux/blkdev.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/blk-settings.c b/block/blk-settings.c
index c50ecf0..994d91c 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -283,7 +283,8 @@ EXPORT_SYMBOL(blk_queue_max_hw_sectors);
void blk_queue_max_discard_sectors(struct request_queue *q,
unsigned int max_discard_sectors)
{
- q->limits.max_discard_sectors = max_discard_sectors;
+ q->limits.max_discard_sectors = min_t(unsigned int, max_discard_sectors,
+ BLK_DEF_MAX_DISCARD_SECTORS);
}
EXPORT_SYMBOL(blk_queue_max_discard_sectors);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 07aa5f6..efff505 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1105,6 +1105,7 @@ enum blk_default_limits {
BLK_DEF_MAX_SECTORS = 1024,
BLK_MAX_SEGMENT_SIZE = 65536,
BLK_SEG_BOUNDARY_MASK = 0xFFFFFFFFUL,
+ BLK_DEF_MAX_DISCARD_SECTORS = UINT_MAX >> 9,
};
#define blkdev_entry_to_request(entry) list_entry((entry), struct request, queuelist)
--
1.7.9.5
reply other threads:[~2013-04-13 13:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365860293-21227-1-git-send-email-linkinjeon@gmail.com \
--to=linkinjeon@gmail.com \
--cc=Paul.Clements@steeleye.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=cjb@laptop.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=neilb@suse.de \
--cc=npiggin@kernel.dk \
--cc=shli@kernel.org \
--cc=t.vivek@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox