From: Adrian Hunter <adrian.hunter@intel.com>
To: Ritesh Harjani <riteshh@codeaurora.org>, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
shawn.lin@rock-chips.com, linux-arm-msm@vger.kernel.org,
georgi.djakov@linaro.org, asutoshd@codeaurora.org,
stummala@codeaurora.org, venkatg@codeaurora.org,
pramod.gurav@linaro.org, jeremymc@redhat.com, git@kchr.de
Subject: Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence
Date: Mon, 30 Jan 2017 11:04:34 +0200 [thread overview]
Message-ID: <13695c9e-e818-59a1-2c1c-27ed2d376085@intel.com> (raw)
In-Reply-To: <1485247827-12898-3-git-send-email-riteshh@codeaurora.org>
On 24/01/17 10:50, Ritesh Harjani wrote:
> This removes CDC init sequence comments which are
> not useful anyway.
>
> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-msm.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index b3e8f44..10cdc84 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -664,19 +664,7 @@ static int sdhci_msm_cdclp533_calibration(struct sdhci_host *host)
> config &= ~CORE_START_CDC_TRAFFIC;
> writel_relaxed(config, host->ioaddr + CORE_DDR_200_CFG);
>
> - /*
> - * Perform CDC Register Initialization Sequence
> - *
> - * CORE_CSR_CDC_CTLR_CFG0 0x11800EC
> - * CORE_CSR_CDC_CTLR_CFG1 0x3011111
> - * CORE_CSR_CDC_CAL_TIMER_CFG0 0x1201000
> - * CORE_CSR_CDC_CAL_TIMER_CFG1 0x4
> - * CORE_CSR_CDC_REFCOUNT_CFG 0xCB732020
> - * CORE_CSR_CDC_COARSE_CAL_CFG 0xB19
> - * CORE_CSR_CDC_DELAY_CFG 0x3AC
> - * CORE_CDC_OFFSET_CFG 0x0
> - * CORE_CDC_SLAVE_DDA_CFG 0x16334
> - */
> + /* Perform CDC Register Initialization Sequence */
>
> writel_relaxed(0x11800EC, host->ioaddr + CORE_CSR_CDC_CTLR_CFG0);
> writel_relaxed(0x3011111, host->ioaddr + CORE_CSR_CDC_CTLR_CFG1);
>
next prev parent reply other threads:[~2017-01-30 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 8:50 [PATCHv1 0/2] mmc: sdhci-msm: Addresses minor cleanups Ritesh Harjani
2017-01-24 8:50 ` [PATCHv1 1/2] mmc: sdhci-msm: Remove platform_execute_tuning from sdhci_msm_ops Ritesh Harjani
2017-01-30 9:04 ` Adrian Hunter
2017-01-30 10:04 ` Ulf Hansson
2017-01-24 8:50 ` [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence Ritesh Harjani
2017-01-30 9:04 ` Adrian Hunter [this message]
2017-01-30 10:04 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13695c9e-e818-59a1-2c1c-27ed2d376085@intel.com \
--to=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=git@kchr.de \
--cc=jeremymc@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pramod.gurav@linaro.org \
--cc=riteshh@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox