From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: 'Jaehoon Chung' <jh80.chung@samsung.com>,
'Chris Ball' <cjb@laptop.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: dw: don't check resource with devm_ioremap_resource
Date: Wed, 05 Jun 2013 17:14:19 +0300 [thread overview]
Message-ID: <1370441659.29283.295.camel@smile> (raw)
In-Reply-To: <001701ce61f5$220667d0$66133770$%jun@samsung.com>
On Wed, 2013-06-05 at 23:01 +0900, Seungwon Jeon wrote:
> On 06/05/13 6:24 PM, Andy Shevchenko wrote:
> > devm_ioremap_resource does sanity checks on the given resource. No need to
> > duplicate this in the driver.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Looks good to me.
> 'dw_mmc'(instead of 'dw') as a prefix of subject is expected with other patches, though.
> Specially, dw_mmc-pci is for PATCH 3/3.
Shall I resubmit patches?
I think no-one can mess up with this, because we fortunately have only
one mmc designware driver there.
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks for review.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-06-05 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 9:24 [PATCH 1/3] mmc: dw: don't check resource with devm_ioremap_resource Andy Shevchenko
2013-06-05 9:24 ` [PATCH 2/3] mmc: dw: eliminate useless usage of ret Andy Shevchenko
2013-06-05 14:01 ` Seungwon Jeon
2013-06-05 9:24 ` [PATCH 3/3] mmc: dw: convert to use pcim_* and devm_* Andy Shevchenko
2013-06-05 14:04 ` Seungwon Jeon
2013-06-05 14:01 ` [PATCH 1/3] mmc: dw: don't check resource with devm_ioremap_resource Seungwon Jeon
2013-06-05 14:14 ` Andy Shevchenko [this message]
2013-06-27 15:25 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370441659.29283.295.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox