* [PATCH 1/1] mmc: sdhci-sirf: Fix build breakage
@ 2013-06-18 8:54 Sachin Kamat
2013-06-21 15:46 ` Christian Daudt
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2013-06-18 8:54 UTC (permalink / raw)
To: linux-mmc; +Cc: cjb, sachin.kamat, Christian Daudt, Barry Song
Commit 0e74823429 ("mmc: sdhci: Add size for caller in init+register")
introduced size parameter to sdhci_pltfm_init(). This driver probably
got left out during the conversion. Passing in zero as done for other
drivers to avoid the following build error:
drivers/mmc/host/sdhci-sirf.c: In function ‘sdhci_sirf_probe’:
drivers/mmc/host/sdhci-sirf.c:78:2: error: too few arguments to function
‘sdhci_pltfm_init’
host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata);
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Christian Daudt <csd@broadcom.com>
Cc: Barry Song <Baohua.Song@csr.com>
---
Compile tested on linux-next (20130618)
---
drivers/mmc/host/sdhci-sirf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c
index 09805af..1a149eb 100644
--- a/drivers/mmc/host/sdhci-sirf.c
+++ b/drivers/mmc/host/sdhci-sirf.c
@@ -75,7 +75,7 @@ static int sdhci_sirf_probe(struct platform_device *pdev)
priv->gpio_cd = -EINVAL;
}
- host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata);
+ host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata, 0);
if (IS_ERR(host)) {
ret = PTR_ERR(host);
goto err_sdhci_pltfm_init;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] mmc: sdhci-sirf: Fix build breakage
2013-06-18 8:54 [PATCH 1/1] mmc: sdhci-sirf: Fix build breakage Sachin Kamat
@ 2013-06-21 15:46 ` Christian Daudt
0 siblings, 0 replies; 2+ messages in thread
From: Christian Daudt @ 2013-06-21 15:46 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-mmc, cjb, Barry Song
On 13-06-18 01:54 AM, Sachin Kamat wrote:
> Commit 0e74823429 ("mmc: sdhci: Add size for caller in init+register")
> introduced size parameter to sdhci_pltfm_init(). This driver probably
> got left out during the conversion. Passing in zero as done for other
> drivers to avoid the following build error:
>
> drivers/mmc/host/sdhci-sirf.c: In function ‘sdhci_sirf_probe’:
> drivers/mmc/host/sdhci-sirf.c:78:2: error: too few arguments to function
> ‘sdhci_pltfm_init’
> host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata);
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Christian Daudt <csd@broadcom.com>
> Cc: Barry Song <Baohua.Song@csr.com>
> ---
> Compile tested on linux-next (20130618)
> ---
> drivers/mmc/host/sdhci-sirf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c
> index 09805af..1a149eb 100644
> --- a/drivers/mmc/host/sdhci-sirf.c
> +++ b/drivers/mmc/host/sdhci-sirf.c
> @@ -75,7 +75,7 @@ static int sdhci_sirf_probe(struct platform_device *pdev)
> priv->gpio_cd = -EINVAL;
> }
>
> - host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata);
> + host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata, 0);
> if (IS_ERR(host)) {
> ret = PTR_ERR(host);
> goto err_sdhci_pltfm_init;
Acked-by: Christian Daudt <csd@broadcom.com>
Thanks,
csd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-21 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-18 8:54 [PATCH 1/1] mmc: sdhci-sirf: Fix build breakage Sachin Kamat
2013-06-21 15:46 ` Christian Daudt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).