From: Scott Wood <scottwood@freescale.com>
Cc: linux-mmc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
cbouatmailru@gmail.com, cjb@laptop.org, AFLEMING@freescale.com,
r39252@freescale.com, Haijun Zhang <Haijun.Zhang@freescale.com>,
Haijun Zhang <haijun.zhang@freescale.com>
Subject: Re: [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board
Date: Mon, 8 Jul 2013 12:18:39 -0500 [thread overview]
Message-ID: <1373303919.8183.164@snotra> (raw)
In-Reply-To: <1373267764-6364-2-git-send-email-Haijun.Zhang@freescale.com> (from Haijun.Zhang@freescale.com on Mon Jul 8 02:16:04 2013)
On 07/08/2013 02:16:04 AM, Haijun Zhang wrote:
> On T4240QDS board controllers has an unusable ADMA engine, so use
> SDMA instead.
> Also 3.0v is support on T4240QDS board even if the capacity detailed
> only 1.8v
> support. Without this quirk SD card will declare voltage not support
> and
>
> Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>
...and what?
Why is this board-specific? Isn't the controller part of the SoC, not
part of the board? If it really is board-specific, could you be more
detailed about why (ideally with an erratum number), and check the
toplevel board compatible (or get the information from platform code)
rather than modify the device tree?
-Scott
next prev parent reply other threads:[~2013-07-08 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 7:16 [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Haijun Zhang
2013-07-08 7:16 ` [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board Haijun Zhang
2013-07-08 17:18 ` Scott Wood [this message]
2013-07-12 18:35 ` Anton Vorontsov
2013-07-16 3:11 ` Zhang Haijun-B42677
2013-07-16 5:04 ` Anton Vorontsov
2013-07-08 17:14 ` [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Scott Wood
2013-07-09 6:04 ` 答复: " Zhang Haijun-B42677
2013-07-09 20:04 ` Scott Wood
2013-07-10 3:41 ` Zhang Haijun-B42677
2013-07-10 20:30 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373303919.8183.164@snotra \
--to=scottwood@freescale.com \
--cc=AFLEMING@freescale.com \
--cc=Haijun.Zhang@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r39252@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox