From: Scott Wood <scottwood@freescale.com>
Cc: linux-mmc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
cbouatmailru@gmail.com, cjb@laptop.org, AFLEMING@freescale.com,
r39252@freescale.com, Haijun Zhang <Haijun.Zhang@freescale.com>,
Haijun Zhang <haijun.zhang@freescale.com>
Subject: Re: [PATCH 1/2] Powerpc: Add voltage support in dts file
Date: Tue, 23 Jul 2013 11:19:20 -0500 [thread overview]
Message-ID: <1374596360.15592.25@snotra> (raw)
In-Reply-To: <1374548345-15017-1-git-send-email-Haijun.Zhang@freescale.com> (from Haijun.Zhang@freescale.com on Mon Jul 22 21:59:04 2013)
On 07/22/2013 09:59:04 PM, Haijun Zhang wrote:
> eSDHC of T4240 had 1.8v voltage support. Add this node to specify
> eSDHC voltage capacity. If this node not specified eSDHC driver
> still can read from eSDHC host capacity register.
>
> Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>
> Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
> ---
> changes for this patch set:
> - split from patch [PATCH 1/2] Powerpc: Add
> - voltage ranges support for T4
>
> Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 3 +++
> arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> index bd9be0b..f1ac253 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> @@ -19,6 +19,8 @@ Optional properties:
> "bus-width = <1>" property.
> - sdhci,auto-cmd12: specifies that a controller can only handle
> auto
> CMD12.
> + - 3300 3300: specifies that eSDHC controller can support voltages
> ranges
> + from 3300 to 3300.
"3300 3300" is not a property name -- and the voltage-ranges property
should be defined more generically, as is done for mmc-spi-slot.txt.
-Scott
prev parent reply other threads:[~2013-07-23 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 2:59 [PATCH 1/2] Powerpc: Add voltage support in dts file Haijun Zhang
2013-07-23 2:59 ` [PATCH 2/2] Powerpc: Add 3.3v voltage support for T4240QDS Haijun Zhang
2013-07-23 16:19 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374596360.15592.25@snotra \
--to=scottwood@freescale.com \
--cc=AFLEMING@freescale.com \
--cc=Haijun.Zhang@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r39252@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox