From: franck.jullien@gmail.com
To: linux-mmc@vger.kernel.org
Cc: Franck Jullien <franck.jullien@gmail.com>
Subject: [PATCH] mmc: fix null pointer use in mmc_blk_remove_req
Date: Wed, 24 Jul 2013 15:17:48 +0200 [thread overview]
Message-ID: <1374671868-606-1-git-send-email-franck.jullien@gmail.com> (raw)
From: Franck Jullien <franck.jullien@gmail.com>
A previous commit (fdfa20c1631210d0) reordered the
shutdown sequence in mmc_blk_remove_req. However,
mmc_cleanup_queue is now called before we get the
card pointer and, sadly, mmc_cleanup_queue set
mq->card to NULL.
This patch moves the card pointer assignment before
mmc_cleanup_queue.
Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
---
drivers/mmc/card/block.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index cd0b7f4..f4a0bea 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -2191,10 +2191,10 @@ static void mmc_blk_remove_req(struct mmc_blk_data *md)
* is freeing the queue that stops new requests
* from being accepted.
*/
+ card = md->queue.card;
mmc_cleanup_queue(&md->queue);
if (md->flags & MMC_BLK_PACKED_CMD)
mmc_packed_clean(&md->queue);
- card = md->queue.card;
if (md->disk->flags & GENHD_FL_UP) {
device_remove_file(disk_to_dev(md->disk), &md->force_ro);
if ((md->area_type & MMC_BLK_DATA_AREA_BOOT) &&
--
1.7.1
next reply other threads:[~2013-07-24 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 13:17 franck.jullien [this message]
2013-07-25 7:20 ` [PATCH] mmc: fix null pointer use in mmc_blk_remove_req Franck Jullien
2013-08-25 3:22 ` Chris Ball
2013-10-07 8:48 ` Adrian Hunter
2013-10-07 8:50 ` Adrian Hunter
2013-10-07 8:54 ` Adrian Hunter
2013-10-10 23:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374671868-606-1-git-send-email-franck.jullien@gmail.com \
--to=franck.jullien@gmail.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox