From: Scott Wood <scottwood@freescale.com>
To: Zhang Haijun <B42677@freescale.com>
Cc: linux-mmc@vger.kernel.org, AFLEMING@freescale.com,
Xie Xiaobo-R63061 <X.Xie@freescale.com>,
cbouatmailru@gmail.com, cjb@laptop.org,
linuxppc-dev@lists.ozlabs.org,
Haijun Zhang <Haijun.Zhang@freescale.com>
Subject: Re: [PATCH 1/3] mmc:core: parse voltage from device-tree
Date: Tue, 30 Jul 2013 14:58:54 -0500 [thread overview]
Message-ID: <1375214334.30721.82@snotra> (raw)
In-Reply-To: <51F71825.9000904@freescale.com> (from B42677@freescale.com on Mon Jul 29 20:34:29 2013)
On 07/29/2013 08:34:29 PM, Zhang Haijun wrote:
> On 07/30/2013 06:07 AM, Scott Wood wrote:
>> On 07/28/2013 09:56:33 PM, Haijun Zhang wrote:
>>> Add function to support get voltage from device-tree.
>>> If there are voltage-range specified in device-tree node, this
>>> function
>>> will parse it and return the avail voltage mask.
>>>
>>> Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>
>>> ---
>>> drivers/mmc/core/core.c | 48
>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>> include/linux/mmc/core.h | 1 +
>>> 2 files changed, 49 insertions(+)
>>
>> Move the code rather than copying it.
>>
>> -Scott
> Hi, Scott
>
> You mean?
The point of factoring this out is to avoid duplicating the code. If
you don't remove it from the place you copied it from (and have that
code call here instead), then you're not avoiding the duplication.
-Scott
prev parent reply other threads:[~2013-07-30 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 2:56 [PATCH 1/3] mmc:core: parse voltage from device-tree Haijun Zhang
2013-07-29 2:56 ` [PATCH 2/3] mmc:sdhc: get voltage from sdhc host Haijun Zhang
2013-07-29 2:56 ` [PATCH 3/3] mmc:esdhc: add support to get voltage from device-tree Haijun Zhang
2013-07-29 22:07 ` [PATCH 1/3] mmc:core: parse " Scott Wood
2013-07-30 1:34 ` Zhang Haijun
2013-07-30 19:58 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375214334.30721.82@snotra \
--to=scottwood@freescale.com \
--cc=AFLEMING@freescale.com \
--cc=B42677@freescale.com \
--cc=Haijun.Zhang@freescale.com \
--cc=X.Xie@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox