From: Dinh Nguyen <dinguyen@altera.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Jingoo Han <jg1.han@samsung.com>, Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, Seungwon Jeon <tgih.jun@samsung.com>
Subject: Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA
Date: Thu, 1 Aug 2013 09:59:13 -0500 [thread overview]
Message-ID: <1375369153.20685.62.camel@linux-builds1> (raw)
In-Reply-To: <51FA7620.9090504@samsung.com>
On Thu, 2013-08-01 at 23:52 +0900, Jaehoon Chung wrote:
> When I used socfpga_defconfig, MFD_SYSCON is enabled.
> Which config do you use?
>
Yes, select MFD_SYSCON is in mach-socfpga/Kconfig. This should have
fixed this error.
commit 1780db9e2104 ARM: socfpga: Add syscon to be part of socfpga
Dinh
> Best Regards,
> Jaehoon Chung
>
> On 08/01/2013 09:28 AM, Jingoo Han wrote:
> > Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
> > the following link error.
> >
> > drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 8a4c066..84102bc 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
> >
> > config MMC_DW_SOCFPGA
> > tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
> > - depends on MMC_DW
> > + depends on MMC_DW && MFD_SYSCON
> > select MMC_DW_PLTFM
> > help
> > This selects support for Altera SoCFPGA specific extensions to the
> >
>
>
next prev parent reply other threads:[~2013-08-01 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 0:28 [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA Jingoo Han
2013-08-01 14:52 ` Jaehoon Chung
2013-08-01 14:59 ` Dinh Nguyen [this message]
2013-08-01 23:22 ` Jingoo Han
2013-08-02 3:48 ` Jaehoon Chung
2013-08-09 13:31 ` Seungwon Jeon
2013-08-25 3:33 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375369153.20685.62.camel@linux-builds1 \
--to=dinguyen@altera.com \
--cc=cjb@laptop.org \
--cc=jg1.han@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox