From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: linux-mmc@vger.kernel.org
Cc: Chris Ball <cjb@laptop.org>,
aaro.koskinen@iki.fi, Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: [PATCH FIX+RESEND 4/7] mmc: omap: Remove mem_res field from struct mmc_omap_host
Date: Sun, 6 Oct 2013 20:36:15 +0300 [thread overview]
Message-ID: <1381080978-29127-4-git-send-email-jarkko.nikula@bitmer.com> (raw)
In-Reply-To: <1381080978-29127-1-git-send-email-jarkko.nikula@bitmer.com>
Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe
when setting the phys_base field so we may just se the phys_base straight
and remove needless mem_res.
Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
---
drivers/mmc/host/omap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 7668d47..ec5defa 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -141,7 +141,6 @@ struct mmc_omap_host {
u32 dma_rx_burst;
struct dma_chan *dma_tx;
u32 dma_tx_burst;
- struct resource *mem_res;
void __iomem *virt_base;
unsigned int phys_base;
int irq;
@@ -1383,10 +1382,9 @@ static int mmc_omap_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, host);
host->id = pdev->id;
- host->mem_res = res;
host->irq = irq;
host->use_dma = 1;
- host->phys_base = host->mem_res->start;
+ host->phys_base = res->start;
host->virt_base = ioremap(res->start, resource_size(res));
if (!host->virt_base)
goto err_ioremap;
--
1.8.4.rc3
next prev parent reply other threads:[~2013-10-06 17:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 17:36 [PATCH FIX+RESEND 1/7] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet Jarkko Nikula
2013-10-06 17:36 ` [PATCH FIX+RESEND 2/7] mmc: omap: Convert to devm_kzalloc Jarkko Nikula
2013-10-06 17:36 ` [PATCH FIX+RESEND 3/7] mmc: omap: Remove duplicate host->irq assignment Jarkko Nikula
2013-10-06 17:36 ` Jarkko Nikula [this message]
2013-10-06 17:36 ` [PATCH FIX+RESEND 5/7] mmc: omap: Convert to devm_ioremap_resource Jarkko Nikula
2013-10-06 17:36 ` [PATCH FIX+RESEND 6/7] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host Jarkko Nikula
2013-10-06 17:36 ` [PATCH FIX+RESEND 7/7] mmc: omap: Get DMA request numbers via platform resource Jarkko Nikula
2013-10-26 14:55 ` [PATCH] mmc: omap: Add erase capability Jarkko Nikula
2013-11-16 15:53 ` [RESEND 1/8] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet Jarkko Nikula
2013-11-16 15:53 ` [RESEND 2/8] mmc: omap: Convert to devm_kzalloc Jarkko Nikula
2013-11-16 15:53 ` [RESEND 3/8] mmc: omap: Remove duplicate host->irq assignment Jarkko Nikula
2013-11-16 15:53 ` [RESEND 4/8] mmc: omap: Remove mem_res field from struct mmc_omap_host Jarkko Nikula
2013-11-16 15:53 ` [RESEND 5/8] mmc: omap: Convert to devm_ioremap_resource Jarkko Nikula
2013-11-16 15:53 ` [RESEND 6/8] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host Jarkko Nikula
2013-11-16 15:53 ` [RESEND 7/8] mmc: omap: Get DMA request numbers via platform resource Jarkko Nikula
2013-11-16 15:53 ` [RESEND 8/8] mmc: omap: Add erase capability Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381080978-29127-4-git-send-email-jarkko.nikula@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=aaro.koskinen@iki.fi \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).