From: Doug Anderson <dianders@chromium.org>
To: Chris Ball <cjb@laptop.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
James Hogan <james.hogan@imgtec.com>,
Grant Grundler <grundler@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Abhilash Kesavan <a.kesavan@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Olof Johansson <olof@lixom.net>,
Sonny Rao <sonnyrao@chromium.org>, Bing Zhao <bzhao@marvell.com>,
Doug Anderson <dianders@chromium.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Prevent races when doing read-modify-write of INTMASK
Date: Tue, 15 Oct 2013 15:39:20 -0700 [thread overview]
Message-ID: <1381876762-10892-1-git-send-email-dianders@chromium.org> (raw)
Bing Zhao at Marvell discovered a race in the way that dw_mmc was
doing a read-modify-write of the INTMASK register. This 2-patch
series attempts to fix the problem using a simple spinlock. In order
to do so cleanly, we include a patch to tidy up the way that we
disable low power mode when using SDIO interrupts.
This patch series was not tested on ToT Linux other than basic
compiling and booting, since we don't have the whole Marvell SDIO
stack up and running in mainline yet. This series is based on
mmc-next (e76b855 mmc: sdhci-esdhc-imx: set actual_clock in clock
setting) merged atop mainlinx Linux.
Doug Anderson (2):
mmc: dw_mmc: Cleanup disable of low power mode w/ SDIO interrupts
mmc: dw_mmc: Protect read-modify-write of INTMASK with a lock
drivers/mmc/host/dw_mmc.c | 79 +++++++++++++++++++++++++++-------------------
drivers/mmc/host/dw_mmc.h | 1 +
include/linux/mmc/dw_mmc.h | 6 ++++
3 files changed, 54 insertions(+), 32 deletions(-)
--
1.8.4
next reply other threads:[~2013-10-15 22:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 22:39 Doug Anderson [this message]
2013-10-15 22:39 ` [PATCH 1/2] mmc: dw_mmc: Cleanup disable of low power mode w/ SDIO interrupts Doug Anderson
2013-10-18 9:42 ` Jaehoon Chung
2013-10-18 20:09 ` Doug Anderson
2013-10-23 11:25 ` Seungwon Jeon
2013-10-24 7:28 ` Doug Anderson
2013-10-25 9:29 ` Seungwon Jeon
2013-10-28 22:39 ` Doug Anderson
2013-11-01 5:23 ` Seungwon Jeon
2013-10-15 22:39 ` [PATCH 2/2] mmc: dw_mmc: Protect read-modify-write of INTMASK with a lock Doug Anderson
2013-10-16 9:49 ` James Hogan
2013-10-16 16:43 ` Doug Anderson
2013-10-16 20:23 ` James Hogan
2013-10-18 9:51 ` Jaehoon Chung
2013-10-18 20:09 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381876762-10892-1-git-send-email-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=a.kesavan@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=bzhao@marvell.com \
--cc=cjb@laptop.org \
--cc=grundler@chromium.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).