From: "Arend van Spriel" <arend@broadcom.com>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, Arend van Spriel <arend@broadcom.com>
Subject: [PATCH] sdhci: do not program timer when tuning_count is zero
Date: Thu, 7 Nov 2013 11:59:19 +0100 [thread overview]
Message-ID: <1383821960-2533-1-git-send-email-arend@broadcom.com> (raw)
When the host->tuning_count is zero it means that the
retuning is disabled. Doing a mod_timer() with a zero
tuning_count does something else.
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
drivers/mmc/host/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 7a7fb4f..9803e7a 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2007,7 +2007,8 @@ out:
} else {
host->flags &= ~SDHCI_NEEDS_RETUNING;
/* Reload the new initial value for timer */
- if (host->tuning_mode == SDHCI_TUNING_MODE_1)
+ if (host->tuning_count &&
+ host->tuning_mode == SDHCI_TUNING_MODE_1)
mod_timer(&host->tuning_timer, jiffies +
host->tuning_count * HZ);
}
--
1.7.10.4
next reply other threads:[~2013-11-07 10:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 10:59 Arend van Spriel [this message]
2013-11-08 6:50 ` [PATCH] sdhci: do not program timer when tuning_count is zero Aaron Lu
2013-11-08 9:10 ` Arend van Spriel
2013-11-08 11:49 ` Aaron Lu
2013-11-08 11:55 ` Arend van Spriel
2013-11-08 13:19 ` Aaron Lu
2013-11-11 9:49 ` [PATCH V2] sdhci: only reprogram retuning timer when flag is set Arend van Spriel
2013-11-12 6:49 ` Aaron Lu
2013-11-13 5:02 ` Dong Aisheng
2013-11-13 10:21 ` Arend van Spriel
2013-11-13 11:12 ` Dong Aisheng
2013-11-13 11:18 ` Arend van Spriel
2013-11-13 11:25 ` Dong Aisheng
2013-11-13 13:01 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383821960-2533-1-git-send-email-arend@broadcom.com \
--to=arend@broadcom.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).