From: John Tobias <john.tobias.ph@gmail.com>
To: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
shawn.guo@linaro.org, festevam@gmail.com, cjb@laptop.org
Cc: John Tobias <john.tobias.ph@gmail.com>
Subject: [PATCH 3/4] Removing imx6q_opp_init
Date: Tue, 17 Dec 2013 17:17:30 -0800 [thread overview]
Message-ID: <1387329451-17480-3-git-send-email-john.tobias.ph@gmail.com> (raw)
In-Reply-To: <1387329451-17480-1-git-send-email-john.tobias.ph@gmail.com>
Since of_init_opp_table is in imx6q-cpufreq.c, the imx6q_opp_init is no longer needed anymore.
The only question right now is the imx6q_opp_check_1p2ghz function.
Is the function below are acceptible under imx6q_init_late?.
if (!cpu_dev)
imx6q_opp_check_1p2ghz(cpu_dev);
If not, what is the better way to impelement because the said function is board specific?.
Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
---
arch/arm/mach-imx/mach-imx6q.c | 30 ++++--------------------------
1 file changed, 4 insertions(+), 26 deletions(-)
diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
index d0cfb22..f5d9e04 100644
--- a/arch/arm/mach-imx/mach-imx6q.c
+++ b/arch/arm/mach-imx/mach-imx6q.c
@@ -183,31 +183,6 @@ put_node:
of_node_put(np);
}
-static void __init imx6q_opp_init(void)
-{
- struct device_node *np;
- struct device *cpu_dev = get_cpu_device(0);
-
- if (!cpu_dev) {
- pr_warn("failed to get cpu0 device\n");
- return;
- }
- np = of_node_get(cpu_dev->of_node);
- if (!np) {
- pr_warn("failed to find cpu0 node\n");
- return;
- }
-
- if (of_init_opp_table(cpu_dev)) {
- pr_warn("failed to init OPP table\n");
- goto put_node;
- }
-
- imx6q_opp_check_1p2ghz(cpu_dev);
-
-put_node:
- of_node_put(np);
-}
static struct platform_device imx6q_cpufreq_pdev = {
.name = "imx6q-cpufreq",
@@ -215,6 +190,7 @@ static struct platform_device imx6q_cpufreq_pdev = {
static void __init imx6q_init_late(void)
{
+ struct device *cpu_dev = get_cpu_device(0);
/*
* WAIT mode is broken on TO 1.0 and 1.1, so there is no point
* to run cpuidle on them.
@@ -223,8 +199,10 @@ static void __init imx6q_init_late(void)
imx6q_cpuidle_init();
if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ)) {
- imx6q_opp_init();
platform_device_register(&imx6q_cpufreq_pdev);
+
+ if (!cpu_dev)
+ imx6q_opp_check_1p2ghz(cpu_dev);
}
}
--
1.8.3.2
next prev parent reply other threads:[~2013-12-18 1:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 1:17 [PATCH 1/4] iMX6SL frequency table John Tobias
2013-12-18 1:17 ` [PATCH 2/4] Moving of_init_opp_table John Tobias
2013-12-18 7:43 ` Shawn Guo
2013-12-18 16:41 ` John Tobias
2013-12-18 1:17 ` John Tobias [this message]
2013-12-18 7:49 ` [PATCH 3/4] Removing imx6q_opp_init Shawn Guo
2013-12-18 16:25 ` John Tobias
2013-12-18 1:17 ` [PATCH 4/4] Added cpufreq support for iMX6SL John Tobias
2013-12-18 7:37 ` [PATCH 1/4] iMX6SL frequency table Shawn Guo
2013-12-18 16:24 ` John Tobias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387329451-17480-3-git-send-email-john.tobias.ph@gmail.com \
--to=john.tobias.ph@gmail.com \
--cc=cjb@laptop.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox