Re: [PATCH 2/3] mmc: Add realtek USB sdmmc host driver

Oliver Neukum
2014-01-10T12:49:03Z

On Mon, 2013-12-23 at 17:52 +0800, rogerable@realtek.com wrote:
> From: Roger Tseng <rogerable@realtek.com>
>
> Realtek USB SD/MMC host driver provides mmc host support based on the Realtek
> USB card reader MFD driver.
>
> Signed-off-by: Roger Tseng <rogerable@realtek.com>

> +#ifdef DEBUG

Dynamic debugging would be nice.

> +static void sd_print_debug_regs(struct rtsx_usb_sdmmc *host)
> +{
> + struct rtsx_ucr *ucr = host->ucr;
> + u8 val = 0;
> +
> + rtsx_usb_ep0_read_register(ucr, SD_STAT1, &val);
> + dev_dbg(sdmmc_dev(host), "SD_STAT1: 0x%x\n", val);
> + rtsx_usb_ep0_read_register(ucr, SD_STAT2, &val);
> + dev_dbg(sdmmc_dev(host), "SD_STAT2: 0x%x\n", val);
> + rtsx_usb_ep0_read_register(ucr, SD_BUS_STAT, &val);
> + dev_dbg(sdmmc_dev(host), "SD_BUS_STAT: 0x%x\n", val);
> +}
> +#else
> +#define sd_print_debug_regs(host)
> +#endif /* DEBUG */
> +

Regards
Oliver