From: Puthikorn Voravootivat <puthik@chromium.org>
To: Chris Ball <chris@printf.net>, Seungwon Jeon <tgih.jun@samsung.com>
Cc: MMC list <linux-mmc@vger.kernel.org>,
Gwendal Grignou <gwendal@chromium.org>,
Grant Grundler <grundler@chromium.org>,
Puthikorn Voravootivat <puthik@chromium.org>
Subject: [PATCH] dw-mmc: enable trim in eMMC device
Date: Fri, 7 Feb 2014 10:39:58 -0800 [thread overview]
Message-ID: <1391798398-24634-1-git-send-email-puthik@chromium.org> (raw)
Force host to have erase capacity to enable trim or
discard feature in supported eMMC device.
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
---
In mmc_init_queue() before setting up the discard function, mmc driver
will call mmc_can_erase() which will always return 0 because the host
erase capacity is not set anywhere. So to enable discard function, we
need to add erase capacity to the host.
drivers/mmc/host/dw_mmc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 55cd110..f47f1c1 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -55,6 +55,8 @@
#define DW_MCI_FREQ_MAX 200000000 /* unit: HZ */
#define DW_MCI_FREQ_MIN 400000 /* unit: HZ */
+#define DW_MCI_DEFAULT_CAPS (MMC_CAP_ERASE)
+
#ifdef CONFIG_MMC_DW_IDMAC
#define IDMAC_INT_CLR (SDMMC_IDMAC_INT_AI | SDMMC_IDMAC_INT_NI | \
SDMMC_IDMAC_INT_CES | SDMMC_IDMAC_INT_DU | \
@@ -2371,6 +2373,8 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
return ERR_PTR(-ENOMEM);
}
+ pdata->caps |= DW_MCI_DEFAULT_CAPS;
+
/* find out number of slots supported */
if (of_property_read_u32(dev->of_node, "num-slots",
&pdata->num_slots)) {
--
1.9.0.rc1.175.g0b1dcb5
next reply other threads:[~2014-02-07 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 18:39 Puthikorn Voravootivat [this message]
2014-02-10 4:07 ` [PATCH] dw-mmc: enable trim in eMMC device Jaehoon Chung
2014-02-10 9:41 ` Ulf Hansson
2014-02-10 9:53 ` Jaehoon Chung
2014-02-10 19:53 ` Puthikorn Voravootivat
2014-02-10 22:54 ` [PATCH v2] mmc: " Puthikorn Voravootivat
2014-02-11 2:48 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391798398-24634-1-git-send-email-puthik@chromium.org \
--to=puthik@chromium.org \
--cc=chris@printf.net \
--cc=grundler@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).