[PATCH RESEND] mmc: Convert to use ATTRIBUTE_GROUPS

[PATCH RESEND] mmc: Convert to use ATTRIBUTE_GROUPS

[Axel Lin]

Use new ATTRIBUTE_GROUPS macro to declare attribute groups.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/mmc/core/mmc.c | 12 ++----------
 drivers/mmc/core/sd.c  | 12 ++----------
 2 files changed, 4 insertions(+), 20 deletions(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index f631f5a..db0f250 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -694,18 +694,10 @@ static struct attribute *mmc_std_attrs[] = {
 	&dev_attr_rel_sectors.attr,
 	NULL,
 };
-
-static struct attribute_group mmc_std_attr_group = {
-	.attrs = mmc_std_attrs,
-};
-
-static const struct attribute_group *mmc_attr_groups[] = {
-	&mmc_std_attr_group,
-	NULL,
-};
+ATTRIBUTE_GROUPS(mmc_std);
 
 static struct device_type mmc_type = {
-	.groups = mmc_attr_groups,
+	.groups = mmc_std_groups,
 };
 
 /*
diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index 6f42050..c52cb77 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -700,18 +700,10 @@ static struct attribute *sd_std_attrs[] = {
 	&dev_attr_serial.attr,
 	NULL,
 };
-
-static struct attribute_group sd_std_attr_group = {
-	.attrs = sd_std_attrs,
-};
-
-static const struct attribute_group *sd_attr_groups[] = {
-	&sd_std_attr_group,
-	NULL,
-};
+ATTRIBUTE_GROUPS(sd_std);
 
 struct device_type sd_type = {
-	.groups = sd_attr_groups,
+	.groups = sd_std_groups,
 };
 
 /*
-- 
1.8.1.2

Re: [PATCH RESEND] mmc: Convert to use ATTRIBUTE_GROUPS

[Axel Lin]

2014-03-08 15:05 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> Use new ATTRIBUTE_GROUPS macro to declare attribute groups.

Hi Chris,
Any comment on this patch?

Regards,
Axel

Re: [PATCH RESEND] mmc: Convert to use ATTRIBUTE_GROUPS

[Ulf Hansson]

On 8 March 2014 08:05, Axel Lin <axel.lin@ingics.com> wrote:
> Use new ATTRIBUTE_GROUPS macro to declare attribute groups.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

> ---
>  drivers/mmc/core/mmc.c | 12 ++----------
>  drivers/mmc/core/sd.c  | 12 ++----------
>  2 files changed, 4 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index f631f5a..db0f250 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -694,18 +694,10 @@ static struct attribute *mmc_std_attrs[] = {
>         &dev_attr_rel_sectors.attr,
>         NULL,
>  };
> -
> -static struct attribute_group mmc_std_attr_group = {
> -       .attrs = mmc_std_attrs,
> -};
> -
> -static const struct attribute_group *mmc_attr_groups[] = {
> -       &mmc_std_attr_group,
> -       NULL,
> -};
> +ATTRIBUTE_GROUPS(mmc_std);
>
>  static struct device_type mmc_type = {
> -       .groups = mmc_attr_groups,
> +       .groups = mmc_std_groups,
>  };
>
>  /*
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 6f42050..c52cb77 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -700,18 +700,10 @@ static struct attribute *sd_std_attrs[] = {
>         &dev_attr_serial.attr,
>         NULL,
>  };
> -
> -static struct attribute_group sd_std_attr_group = {
> -       .attrs = sd_std_attrs,
> -};
> -
> -static const struct attribute_group *sd_attr_groups[] = {
> -       &sd_std_attr_group,
> -       NULL,
> -};
> +ATTRIBUTE_GROUPS(sd_std);
>
>  struct device_type sd_type = {
> -       .groups = sd_attr_groups,
> +       .groups = sd_std_groups,
>  };
>
>  /*
> --
> 1.8.1.2
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html