From: <rogerable@realtek.com>
To: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>, Chris Ball <chris@printf.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oliver Neukum <oneukum@suse.de>
Cc: driverdev-devel@linuxdriverproject.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
wei_wang@realsil.com.cn, rogerable@realtek.com
Subject: [PATCH v7 2/4] [v6 fix] mfd/rtsx_usb: add comment in rtsx_usb_suspend
Date: Fri, 11 Apr 2014 14:53:21 +0800 [thread overview]
Message-ID: <1397199203-2235-3-git-send-email-rogerable@realtek.com> (raw)
In-Reply-To: <1397199203-2235-1-git-send-email-rogerable@realtek.com>
From: Roger Tseng <rogerable@realtek.com>
Explain why there is no need to have a symmetric LED turn-on in resume handler
while calling rtsx_usb_turn_off_led() in suspend handler.
Signed-off-by: Roger Tseng <rogerable@realtek.com>
---
drivers/mfd/rtsx_usb.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c
index 0ca7973..141ea52 100644
--- a/drivers/mfd/rtsx_usb.c
+++ b/drivers/mfd/rtsx_usb.c
@@ -687,9 +687,15 @@ static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t message)
dev_dbg(&intf->dev, "%s called with pm message 0x%04u\n",
__func__, message.event);
+ /*
+ * Call to make sure LED is off during suspend to save more power.
+ * It is NOT a permanent state and could be turned on anytime later.
+ * Thus no need to call turn_on when resunming.
+ */
mutex_lock(&ucr->dev_mutex);
rtsx_usb_turn_off_led(ucr);
mutex_unlock(&ucr->dev_mutex);
+
return 0;
}
--
1.8.2
next prev parent reply other threads:[~2014-04-11 6:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 6:53 [PATCH v7 0/4] Add modules for realtek USB card reader rogerable
2014-04-11 6:53 ` [PATCH v7 1/4] [v6 fix] mfd/rtsx_usb: fix possible race condition rogerable
2014-04-16 10:39 ` Lee Jones
2014-04-11 6:53 ` rogerable [this message]
2014-04-16 10:40 ` [PATCH v7 2/4] [v6 fix] mfd/rtsx_usb: add comment in rtsx_usb_suspend Lee Jones
2014-04-11 6:53 ` [PATCH v7 3/4] mmc: Add realtek USB sdmmc host driver rogerable
2014-04-28 10:10 ` Lee Jones
2014-04-11 6:53 ` [PATCH v7 4/4] memstick: Add realtek USB memstick " rogerable
2014-04-16 8:13 ` Lee Jones
2014-04-25 7:06 ` Roger
2014-04-25 9:52 ` Dan Carpenter
2014-04-28 10:10 ` Lee Jones
2014-04-30 7:56 ` Roger
2014-05-23 11:47 ` Greg Kroah-Hartman
2014-04-11 7:31 ` [PATCH v7 0/4] Add modules for realtek USB card reader Oliver Neukum
2014-04-11 10:28 ` Lee Jones
2014-04-11 10:36 ` Oliver Neukum
2014-04-16 3:19 ` Roger
2014-04-16 7:27 ` Ulf Hansson
2014-04-16 8:09 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397199203-2235-3-git-send-email-rogerable@realtek.com \
--to=rogerable@realtek.com \
--cc=akpm@linux-foundation.org \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=oakad@yahoo.com \
--cc=oneukum@suse.de \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox