* [PATCH] mmc: sd: warn if card stays busy during init
@ 2014-05-23 14:15 Johan Rudholm
2014-06-16 10:20 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Johan Rudholm @ 2014-05-23 14:15 UTC (permalink / raw)
To: linux-mmc, Chris Ball, Ulf Hansson
Cc: Jesper Nilsson, jrudholm, Johan Rudholm
The initialization of some SD-cards fails because the card never
leaves the busy state. Aid trouble shooting by indicating this in the
kernel log.
Signed-off-by: Johan Rudholm <johanru@axis.com>
---
drivers/mmc/core/sd_ops.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
index 274ef00..48d0c93 100644
--- a/drivers/mmc/core/sd_ops.c
+++ b/drivers/mmc/core/sd_ops.c
@@ -184,6 +184,9 @@ int mmc_send_app_op_cond(struct mmc_host *host, u32 ocr, u32 *rocr)
mmc_delay(10);
}
+ if (!i)
+ pr_err("%s: card never left busy state\n", mmc_hostname(host));
+
if (rocr && !mmc_host_is_spi(host))
*rocr = cmd.resp[0];
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: sd: warn if card stays busy during init
2014-05-23 14:15 [PATCH] mmc: sd: warn if card stays busy during init Johan Rudholm
@ 2014-06-16 10:20 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2014-06-16 10:20 UTC (permalink / raw)
To: Johan Rudholm
Cc: linux-mmc, Chris Ball, Jesper Nilsson, Johan Rudholm,
Johan Rudholm
On 23 May 2014 16:15, Johan Rudholm <johan.rudholm@axis.com> wrote:
> The initialization of some SD-cards fails because the card never
> leaves the busy state. Aid trouble shooting by indicating this in the
> kernel log.
>
> Signed-off-by: Johan Rudholm <johanru@axis.com>
Thanks! Applied for next.
Kind regards
Uffe
> ---
> drivers/mmc/core/sd_ops.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
> index 274ef00..48d0c93 100644
> --- a/drivers/mmc/core/sd_ops.c
> +++ b/drivers/mmc/core/sd_ops.c
> @@ -184,6 +184,9 @@ int mmc_send_app_op_cond(struct mmc_host *host, u32 ocr, u32 *rocr)
> mmc_delay(10);
> }
>
> + if (!i)
> + pr_err("%s: card never left busy state\n", mmc_hostname(host));
> +
> if (rocr && !mmc_host_is_spi(host))
> *rocr = cmd.resp[0];
>
> --
> 1.7.2.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-16 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-23 14:15 [PATCH] mmc: sd: warn if card stays busy during init Johan Rudholm
2014-06-16 10:20 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).