* [PATCH] mmc: block: change stop errors to info
@ 2014-09-17 7:50 Johan Rudholm
2014-09-17 23:01 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Johan Rudholm @ 2014-09-17 7:50 UTC (permalink / raw)
To: ulf.hansson, cjb; +Cc: linux-mmc, Johan Rudholm
Stop command errors are not fatal to the transfer since we make sure
that the card returns to the transfer state and check the card status.
Change an unnecessary error to an info.
Signed-off-by: Johan Rudholm <johanru@axis.com>
---
drivers/mmc/card/block.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 452782b..fea0376 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -977,7 +977,7 @@ static int mmc_blk_cmd_recovery(struct mmc_card *card, struct request *req,
return ERR_CONTINUE;
/* Now for stop errors. These aren't fatal to the transfer. */
- pr_err("%s: error %d sending stop command, original cmd response %#x, card status %#x\n",
+ pr_info("%s: error %d sending stop command, original cmd response %#x, card status %#x\n",
req->rq_disk->disk_name, brq->stop.error,
brq->cmd.resp[0], status);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: block: change stop errors to info
2014-09-17 7:50 [PATCH] mmc: block: change stop errors to info Johan Rudholm
@ 2014-09-17 23:01 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2014-09-17 23:01 UTC (permalink / raw)
To: Johan Rudholm; +Cc: Chris Ball, linux-mmc, Johan Rudholm
On 17 September 2014 09:50, Johan Rudholm <johan.rudholm@axis.com> wrote:
> Stop command errors are not fatal to the transfer since we make sure
> that the card returns to the transfer state and check the card status.
> Change an unnecessary error to an info.
>
> Signed-off-by: Johan Rudholm <johanru@axis.com>
Thanks! Applied for next.
Kind regards
Uffe
> ---
> drivers/mmc/card/block.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 452782b..fea0376 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -977,7 +977,7 @@ static int mmc_blk_cmd_recovery(struct mmc_card *card, struct request *req,
> return ERR_CONTINUE;
>
> /* Now for stop errors. These aren't fatal to the transfer. */
> - pr_err("%s: error %d sending stop command, original cmd response %#x, card status %#x\n",
> + pr_info("%s: error %d sending stop command, original cmd response %#x, card status %#x\n",
> req->rq_disk->disk_name, brq->stop.error,
> brq->cmd.resp[0], status);
>
> --
> 1.7.2.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-17 23:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 7:50 [PATCH] mmc: block: change stop errors to info Johan Rudholm
2014-09-17 23:01 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox