From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Chris Ball <chris@printf.net>
Cc: linux-mmc <linux-mmc@vger.kernel.org>
Subject: [PATCH 6/6] mmc: sdhci: Transfer Complete has higher priority than Data Timeout Error
Date: Tue, 23 Sep 2014 23:00:30 +0300 [thread overview]
Message-ID: <1411502430-25535-7-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1411502430-25535-1-git-send-email-adrian.hunter@intel.com>
According to the SD Host Controller Standard Specification:
"...Transfer Complete has higher priority than Data Timeout
Error. If both bits are set to 1, execution of a command
can be considered to be completed."
Adjust the checking of SDHCI_INT_DATA_TIMEOUT and
SDHCI_INT_DATA_END (Transfer Complete) accordingly.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
drivers/mmc/host/sdhci.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 7481bd8..7a8586f 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2329,11 +2329,6 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
* above in sdhci_cmd_irq().
*/
if (host->cmd && (host->cmd->flags & MMC_RSP_BUSY)) {
- if (intmask & SDHCI_INT_DATA_TIMEOUT) {
- host->cmd->error = -ETIMEDOUT;
- tasklet_schedule(&host->finish_tasklet);
- return;
- }
if (intmask & SDHCI_INT_DATA_END) {
/*
* Some cards handle busy-end interrupt
@@ -2346,6 +2341,11 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
host->busy_handle = 1;
return;
}
+ if (intmask & SDHCI_INT_DATA_TIMEOUT) {
+ host->cmd->error = -ETIMEDOUT;
+ tasklet_schedule(&host->finish_tasklet);
+ return;
+ }
}
pr_err("%s: Got data interrupt 0x%08x even "
@@ -2356,7 +2356,8 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
return;
}
- if (intmask & SDHCI_INT_DATA_TIMEOUT)
+ if ((intmask & SDHCI_INT_DATA_TIMEOUT) &&
+ !(intmask & SDHCI_INT_DATA_END))
host->data->error = -ETIMEDOUT;
else if (intmask & SDHCI_INT_DATA_END_BIT)
host->data->error = -EILSEQ;
--
1.8.3.2
prev parent reply other threads:[~2014-09-23 20:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 20:00 [PATCH 0/6] mmc: Some misc patches Adrian Hunter
2014-09-23 20:00 ` [PATCH 1/6] mmc: Fix use of wrong device in mmc_gpiod_free_cd() Adrian Hunter
2014-09-29 9:44 ` Ulf Hansson
2014-09-23 20:00 ` [PATCH 2/6] mmc: Fix incorrect warning when setting 0 Hz via debugfs Adrian Hunter
2014-09-29 9:44 ` Ulf Hansson
2014-09-23 20:00 ` [PATCH 3/6] mmc: It is not an error for the card to be removed while suspended Adrian Hunter
2014-09-25 8:27 ` Ulf Hansson
2014-09-25 9:26 ` Adrian Hunter
2014-09-23 20:00 ` [PATCH 4/6] mmc: block: Fix error recovery stop cmd timeout calculation Adrian Hunter
2014-09-25 8:37 ` Ulf Hansson
2014-09-23 20:00 ` [PATCH 5/6] mmc: block: Fix SD card stop cmd response type Adrian Hunter
2014-09-25 9:20 ` Ulf Hansson
2014-09-30 11:21 ` Adrian Hunter
2014-09-30 12:09 ` Ulf Hansson
2014-09-30 12:41 ` Adrian Hunter
2014-10-01 8:36 ` Ulf Hansson
2014-09-23 20:00 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411502430-25535-7-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox