From: Mike Looijmans <mike.looijmans@topic.nl>
To: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: michal.simek@xilinx.com, chris@printf.net,
ulf.hansson@linaro.org, Mike Looijmans <mike.looijmans@topic.nl>
Subject: [PATCH 1/2] mmc/host/sdhci-of-arasan.c: Use signed formatting in error messages
Date: Thu, 23 Oct 2014 13:31:00 +0200 [thread overview]
Message-ID: <1414063861-5491-1-git-send-email-mike.looijmans@topic.nl> (raw)
"ret" is a signed int, so use "%d" in format strings instead of "%u".
This prevents cryptic codes in error messages like this:
sdhci-arasan e0101000.sdhci: platform register failed (4294966779)
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 8cf81c3..7ac6718 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -161,7 +161,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
host = sdhci_pltfm_init(pdev, &sdhci_arasan_pdata, 0);
if (IS_ERR(host)) {
ret = PTR_ERR(host);
- dev_err(&pdev->dev, "platform init failed (%u)\n", ret);
+ dev_err(&pdev->dev, "platform init failed (%d)\n", ret);
goto clk_disable_all;
}
@@ -172,7 +172,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
ret = sdhci_add_host(host);
if (ret) {
- dev_err(&pdev->dev, "platform register failed (%u)\n", ret);
+ dev_err(&pdev->dev, "platform register failed (%d)\n", ret);
goto err_pltfm_free;
}
--
1.7.9.5
next reply other threads:[~2014-10-23 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 11:31 Mike Looijmans [this message]
2014-10-23 11:31 ` [PATCH 2/2] mmc/host/sdhci-of-arasan.c: Skip EPROBE_DEFER error messages Mike Looijmans
2014-10-23 11:47 ` Michal Simek
2014-10-27 15:33 ` Ulf Hansson
2014-10-28 7:53 ` Mike Looijmans
2014-10-28 7:53 ` [PATCH] mmc/host/sdhci-of-arasan.c: Omit superfluous " Mike Looijmans
2014-10-28 9:49 ` Ulf Hansson
2014-10-27 15:38 ` [PATCH 1/2] mmc/host/sdhci-of-arasan.c: Use signed formatting in " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414063861-5491-1-git-send-email-mike.looijmans@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=chris@printf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox