public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: linux-mmc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, michal.simek@xilinx.com,
	chris@printf.net, ulf.hansson@linaro.org,
	Mike Looijmans <mike.looijmans@topic.nl>
Subject: [PATCH] mmc/host/sdhci-of-arasan.c: Omit superfluous error messages
Date: Tue, 28 Oct 2014 08:53:21 +0100	[thread overview]
Message-ID: <1414482801-3773-2-git-send-email-mike.looijmans@topic.nl> (raw)
In-Reply-To: <1414482801-3773-1-git-send-email-mike.looijmans@topic.nl>

sdhci_add_host and sdhci_platfm_init already report failure,
so don't emit error messages when a failure occurs. This prevents
occurences of "deferred" messages when required power supplies
are not ready for operation yet.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 drivers/mmc/host/sdhci-of-arasan.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 7ac6718..75bea2e 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -161,7 +161,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
 	host = sdhci_pltfm_init(pdev, &sdhci_arasan_pdata, 0);
 	if (IS_ERR(host)) {
 		ret = PTR_ERR(host);
-		dev_err(&pdev->dev, "platform init failed (%d)\n", ret);
 		goto clk_disable_all;
 	}
 
@@ -171,10 +170,8 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
 	pltfm_host->clk = clk_xin;
 
 	ret = sdhci_add_host(host);
-	if (ret) {
-		dev_err(&pdev->dev, "platform register failed (%d)\n", ret);
+	if (ret)
 		goto err_pltfm_free;
-	}
 
 	return 0;
 
-- 
1.7.9.5

  reply	other threads:[~2014-10-28  7:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23 11:31 [PATCH 1/2] mmc/host/sdhci-of-arasan.c: Use signed formatting in error messages Mike Looijmans
2014-10-23 11:31 ` [PATCH 2/2] mmc/host/sdhci-of-arasan.c: Skip EPROBE_DEFER " Mike Looijmans
2014-10-23 11:47   ` Michal Simek
2014-10-27 15:33     ` Ulf Hansson
2014-10-28  7:53       ` Mike Looijmans
2014-10-28  7:53         ` Mike Looijmans [this message]
2014-10-28  9:49           ` [PATCH] mmc/host/sdhci-of-arasan.c: Omit superfluous " Ulf Hansson
2014-10-27 15:38 ` [PATCH 1/2] mmc/host/sdhci-of-arasan.c: Use signed formatting in " Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414482801-3773-2-git-send-email-mike.looijmans@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=chris@printf.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox