[PATCH 0/3] mmc: FFU for eMMC v5.0

[PATCH 0/3] mmc: FFU for eMMC v5.0

[Avi Shchislowski]

 The Field Firmware Update (FFU) feature is new for eMMC 5.0 spec (Jedec:
 JESD84-B50.pdf)
   
 http://www.jedec.org/standards-documents/technology-focus-areas/flash-memory-ssds-ufs-emmc/e-mmc

 
 
 * This solution allows to:
  - Complete eMMC 5.0 FFU procedure as an atomic operation, without being interrupted by other IO requests
  - Not limited Firmware data size. Using Multiple Write operations.
  - Support of both EXT_CSD_MODE_OPERATION_CODES modes
 * The solution is using "udev" device manager to transfer FW data from user space to eMMC driver
 * Pre-existing functions from mmc_test were used in this solution.

 *New ioctl has been add:
  -transfer the new Firmware data from user space
   to the eMMC deivce and install the newfirmware.
 
Signed-off-by: Avi Shchislowski <avi.shchislowski@sandisk.com>
Signed-off-by: Alex Lemberg <alex.lemberg@sandisk.com>


Avi Shchislowski (3):
  mmc: Add eMMC5.0 ffu ext_csd field
  mmc: move some mmc_test.c function to core.c
  mmc: Support FFU for eMMC v5.0

 drivers/mmc/card/Kconfig    |    8 +
 drivers/mmc/card/block.c    |    5 +
 drivers/mmc/card/mmc_test.c |   97 +--------
 drivers/mmc/core/Makefile   |    1 +
 drivers/mmc/core/core.c     |  128 ++++++++++++
 drivers/mmc/core/mmc.c      |    3 +
 drivers/mmc/core/mmc_ffu.c  |  487 +++++++++++++++++++++++++++++++++++++++++++
 include/linux/mmc/card.h    |    1 +
 include/linux/mmc/core.h    |   30 +++
 include/linux/mmc/mmc.h     |    8 +
 10 files changed, 682 insertions(+), 86 deletions(-)
 create mode 100644 drivers/mmc/core/mmc_ffu.c

-- 
1.7.9.5

Re: [PATCH 0/3] mmc: FFU for eMMC v5.0

[Ulf Hansson]

On 13 November 2014 17:28, Avi Shchislowski
<avi.shchislowski@sandisk.com> wrote:
>  The Field Firmware Update (FFU) feature is new for eMMC 5.0 spec (Jedec:
>  JESD84-B50.pdf)
>
>  http://www.jedec.org/standards-documents/technology-focus-areas/flash-memory-ssds-ufs-emmc/e-mmc
>
>
>
>  * This solution allows to:
>   - Complete eMMC 5.0 FFU procedure as an atomic operation, without being interrupted by other IO requests
>   - Not limited Firmware data size. Using Multiple Write operations.
>   - Support of both EXT_CSD_MODE_OPERATION_CODES modes
>  * The solution is using "udev" device manager to transfer FW data from user space to eMMC driver
>  * Pre-existing functions from mmc_test were used in this solution.
>
>  *New ioctl has been add:
>   -transfer the new Firmware data from user space
>    to the eMMC deivce and install the newfirmware.
>
> Signed-off-by: Avi Shchislowski <avi.shchislowski@sandisk.com>
> Signed-off-by: Alex Lemberg <alex.lemberg@sandisk.com>

Guys, this isn't working. I am unable to review your patches!

1. I don't know what the patches do, because the commit
messages/headers are really poor.
2. Patches are too big.
3. You are mixing logical changes into one patch. Like when you move
code and change code in one patch. That's two different things and
thus should be kept separate.

Please go back and re-work this thoroughly before you decide to send a
new version.

Moreover I also think you need to read
"Documentation/SubmittingPatches", that should give you some more
hints on how to improve and help me as a maintainer.

Kind regards
Uffe