* [PATCH] mmc: mxs-mmc: Register the irq with the device name
@ 2014-11-18 2:37 Fabio Estevam
2014-11-19 11:00 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2014-11-18 2:37 UTC (permalink / raw)
To: ulf.hansson; +Cc: linux-mmc, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Instead of registering the irq name with the driver's name, it's better to pass
the device name so that we have a more explicit indication as to what mmc
instance the irq is related:
$ cat /proc/interrupts
CPU0
...
26: 6 - 96 80010000.ssp
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mmc/host/mxs-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index cd74e51..339059a 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -660,7 +660,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mmc);
ret = devm_request_irq(&pdev->dev, irq_err, mxs_mmc_irq_handler, 0,
- DRIVER_NAME, host);
+ dev_name(&pdev->dev), host);
if (ret)
goto out_free_dma;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: mxs-mmc: Register the irq with the device name
2014-11-18 2:37 [PATCH] mmc: mxs-mmc: Register the irq with the device name Fabio Estevam
@ 2014-11-19 11:00 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2014-11-19 11:00 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-mmc, Fabio Estevam
On 18 November 2014 03:37, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Instead of registering the irq name with the driver's name, it's better to pass
> the device name so that we have a more explicit indication as to what mmc
> instance the irq is related:
>
> $ cat /proc/interrupts
> CPU0
> ...
> 26: 6 - 96 80010000.ssp
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Thanks! Applied for next.
Kind regards
Uffe
> ---
> drivers/mmc/host/mxs-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index cd74e51..339059a 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -660,7 +660,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, mmc);
>
> ret = devm_request_irq(&pdev->dev, irq_err, mxs_mmc_irq_handler, 0,
> - DRIVER_NAME, host);
> + dev_name(&pdev->dev), host);
> if (ret)
> goto out_free_dma;
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-19 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-18 2:37 [PATCH] mmc: mxs-mmc: Register the irq with the device name Fabio Estevam
2014-11-19 11:00 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox