From: Johan Rudholm <johan.rudholm@axis.com>
To: linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Adrian Hunter" <adrian.hunter@intel.com>,
"Guennadi Liakhovetski" <g.liakhovetski@gmx.de>,
"David Lanzendörfer" <david.lanzendoerfer@o2s.ch>,
"Jesper Nilsson" <jespern@axis.com>,
"Johan Rudholm" <johanru@axis.com>
Subject: [PATCH v7 0/3] mmc: core: hw_reset changes
Date: Mon, 12 Jan 2015 15:38:03 +0100 [thread overview]
Message-ID: <1421073486-10903-1-git-send-email-johanru@axis.com> (raw)
Make the mmc_hw_reset routine more generic, by putting the (e)MMC-
specific stuff in the new bus_ops->reset in mmc.c. Add a
bus_ops->reset for SD cards, allowing them to be restarted when
errors occur.
For MMC cards, always check if the reset was sucessful. This allows
us to remove the mmc_hw_reset_check() interface.
As I don't have an eMMC device myself, much less one with a reset line,
I'd be very happy if someone could help me test the code with an eMMC?
v7:
- Rename bus_ops->hw_reset to reset
- Move the send_status check to mmc.c
- Put the changes concerning mmc_hw_reset_check in a separate patch
v6:
- Always perform the mmc_send_status reset check, which allows us to
have only one interface to the card reset functions
- Because of this, add the bus_ops->hw_reset to sd.c instead of
falling back to a power_cycle
v5:
- Move the mmc_test-specific code to mmc_test.c
- Fall back to a power_cycle if the bus_ops->hw_reset is missing
- Because of this, skip the bus_ops->hw_reset in sd.c
v4:
- Rebase onto next
v3:
- Keep mmc_can_reset
- Always set bus_mode = MMC_BUSMODE_PUSHPULL in mmc_set_initial_state()
v2:
- Call the new bus_ops member hw_reset instead of power_reset
- Create mmc_set_initial_state and call it from mmc_mmc_hw_reset
instead of mmc_power_up
- Keep "mmc_hw_reset" naming
Johan Rudholm (3):
mmc: core: always check status after reset
mmc: core: refactor the hw_reset routines
mmc: sd: add reset bus_ops callback
drivers/mmc/card/mmc_test.c | 18 +++++--------
drivers/mmc/core/core.c | 59 +++++++-----------------------------------
drivers/mmc/core/core.h | 1 +
drivers/mmc/core/mmc.c | 41 +++++++++++++++++++++++++++++
drivers/mmc/core/sd.c | 7 +++++
include/linux/mmc/core.h | 1 -
6 files changed, 66 insertions(+), 61 deletions(-)
--
1.7.2.5
next reply other threads:[~2015-01-12 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 14:38 Johan Rudholm [this message]
2015-01-12 14:38 ` [PATCH v7 1/3] mmc: core: always check status after reset Johan Rudholm
2015-01-12 14:38 ` [PATCH v7 2/3] mmc: core: refactor the hw_reset routines Johan Rudholm
2015-01-12 14:38 ` [PATCH v7 3/3] mmc: sd: add reset bus_ops callback Johan Rudholm
2015-01-12 15:11 ` [PATCH v7 0/3] mmc: core: hw_reset changes Ulf Hansson
2015-01-13 8:19 ` Ulf Hansson
2015-01-13 8:26 ` Johan Rudholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421073486-10903-1-git-send-email-johanru@axis.com \
--to=johan.rudholm@axis.com \
--cc=adrian.hunter@intel.com \
--cc=chris@printf.net \
--cc=david.lanzendoerfer@o2s.ch \
--cc=g.liakhovetski@gmx.de \
--cc=jespern@axis.com \
--cc=johanru@axis.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox