From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Chris Ball <chris@printf.net>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Aaron Lu <aaron.lu@intel.com>, Philip Rakity <prakity@nvidia.com>,
Girish K S <girish.shivananjappa@linaro.org>,
Al Cooper <alcooperx@gmail.com>,
Arend van Spriel <arend@broadcom.com>
Subject: [PATCH V2 00/15] mmc: host: Add facility to support re-tuning
Date: Thu, 29 Jan 2015 11:00:15 +0200 [thread overview]
Message-ID: <1422522030-17793-1-git-send-email-adrian.hunter@intel.com> (raw)
Hi
Here is V2 of some patches to move re-tuning support
out of sdhci and into the core, and add support for HS400
re-tuning.
Currently sdhci does re-tuning transparently by
calling sdhci_execute_tuning() from its ->request()
function.
The problem with HS400 re-tuning is that it must be
done in HS200 mode. That means using switch commands
and making ios changes. That means it potentially
conflicts with other command sequences. The new
re-tuning support accomodates that, however it is
not strictly necessary because HS400 re-tuning
should only be needed after runtime suspend when
there would not be a conflict.
Nevertheless, this approach has more structure
and potentially more flexibility.
Changes in V2:
Added support to the block driver for re-tuning
and retrying after a CRC error. The host driver
is left to decide when an error indicates re-tuning
is needed. The block driver will retry a data request
once if re-tuning is flagged as needed.
SDIO drivers need not be aware of re-tuning because
retrying will anyway cause re-tuning when re-tuning
is flagged as needed. Nevertheless SDIO drivers could
use the need_retune flag to instigate a retry when
otherwise they might not have.
mmc: core: Simplify by adding mmc_execute_tuning()
Dropped because it has been applied
mmc: host: Add facility to support re-tuning
Renamed mmc_retune_retry() to mmc_retune_recheck()
to better reflect what it does.
mmc: core: Move mmc_card_removed() into mmc_start_request()
Dropped because it has been applied
mmc: core: Add support for re-tuning before each request
Fixed un-balanced re-tune hold / release
mmc: sdhci: Always init buf_ready_int
Dropped because it has been applied
mmc: core: Separate out the mmc_switch status check so it can be re-used
New patch
mmc: core: Add support for HS400 re-tuning
It was found that that the original code was not reliable
after a CRC error. The problem was that the CMD13 after a
switch was faiing. So the code was changed to check the
switch status *after* changing the I/O state to match the
switch i.e. the new I/O state is the correct one to use
after a switch.
mmc: sdhci: Flag re-tuning is needed on CRC or End-Bit errors
New patch
mmc: block: Check re-tuning in the recovery path
New patch
mmc: block: Retry data requests when re-tuning is needed
New patch
mmc: core: Don't print reset warning if reset is not supported
New patch
Adrian Hunter (15):
mmc: host: Add facility to support re-tuning
mmc: core: Disable re-tuning when card is no longer initialized
mmc: core: Add support for re-tuning before each request
mmc: core: Check re-tuning before retrying
mmc: core: Hold re-tuning during switch commands
mmc: core: Hold re-tuning during erase commands
mmc: core: Hold re-tuning while bkops ongoing
mmc: mmc: Comment that callers need to hold re-tuning if the card is put to sleep
mmc: core: Separate out the mmc_switch status check so it can be re-used
mmc: core: Add support for HS400 re-tuning
mmc: sdhci: Change to new way of doing re-tuning
mmc: sdhci: Flag re-tuning is needed on CRC or End-Bit errors
mmc: block: Check re-tuning in the recovery path
mmc: block: Retry data requests when re-tuning is needed
mmc: core: Don't print reset warning if reset is not supported
drivers/mmc/card/block.c | 19 ++++++-
drivers/mmc/card/queue.h | 1 +
drivers/mmc/core/core.c | 51 ++++++++++++++++--
drivers/mmc/core/core.h | 2 +
drivers/mmc/core/host.c | 63 ++++++++++++++++++++++
drivers/mmc/core/mmc.c | 87 +++++++++++++++++++++++++++++++
drivers/mmc/core/mmc_ops.c | 45 ++++++++++------
drivers/mmc/core/mmc_ops.h | 1 +
drivers/mmc/host/sdhci.c | 127 ++++++++-------------------------------------
include/linux/mmc/host.h | 58 +++++++++++++++++++++
include/linux/mmc/sdhci.h | 3 --
11 files changed, 328 insertions(+), 129 deletions(-)
Regards
Adrian
next reply other threads:[~2015-01-29 9:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 9:00 Adrian Hunter [this message]
2015-01-29 9:00 ` [PATCH V2 01/15] mmc: host: Add facility to support re-tuning Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 02/15] mmc: core: Disable re-tuning when card is no longer initialized Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 03/15] mmc: core: Add support for re-tuning before each request Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 04/15] mmc: core: Check re-tuning before retrying Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 05/15] mmc: core: Hold re-tuning during switch commands Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 06/15] mmc: core: Hold re-tuning during erase commands Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 07/15] mmc: core: Hold re-tuning while bkops ongoing Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 08/15] mmc: mmc: Comment that callers need to hold re-tuning if the card is put to sleep Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 09/15] mmc: core: Separate out the mmc_switch status check so it can be re-used Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 10/15] mmc: core: Add support for HS400 re-tuning Adrian Hunter
2015-02-04 13:35 ` [PATCH V3 " Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 11/15] mmc: sdhci: Change to new way of doing re-tuning Adrian Hunter
2015-03-06 12:51 ` Ulf Hansson
2015-03-09 8:37 ` Adrian Hunter
2015-03-10 13:55 ` Ulf Hansson
2015-03-10 14:20 ` Adrian Hunter
2015-03-23 12:54 ` Ulf Hansson
2015-03-23 14:26 ` Adrian Hunter
2015-03-23 15:02 ` Ulf Hansson
2015-03-23 21:11 ` Adrian Hunter
2015-03-24 21:12 ` Ulf Hansson
2015-03-25 13:48 ` Adrian Hunter
2015-03-26 16:06 ` Ulf Hansson
2015-03-27 9:54 ` Adrian Hunter
2015-03-27 12:04 ` Adrian Hunter
2015-03-24 2:49 ` NeilBrown
2015-03-24 9:40 ` Ulf Hansson
2015-01-29 9:00 ` [PATCH V2 12/15] mmc: sdhci: Flag re-tuning is needed on CRC or End-Bit errors Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 13/15] mmc: block: Check re-tuning in the recovery path Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 14/15] mmc: block: Retry data requests when re-tuning is needed Adrian Hunter
2015-02-27 12:55 ` [PATCH V3 14/15] mmc: block: Retry errored " Adrian Hunter
2015-01-29 9:00 ` [PATCH V2 15/15] mmc: core: Don't print reset warning if reset is not supported Adrian Hunter
2015-02-09 9:33 ` Arend van Spriel
2015-02-09 9:47 ` Adrian Hunter
2015-02-09 16:05 ` Johan Rudholm
2015-02-09 8:43 ` [PATCH V2 00/15] mmc: host: Add facility to support re-tuning Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422522030-17793-1-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=aaron.lu@intel.com \
--cc=alcooperx@gmail.com \
--cc=arend@broadcom.com \
--cc=chris@printf.net \
--cc=girish.shivananjappa@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox