Re: [PATCH V2 15/15] mmc: core: Don't print reset warning if reset is not supported

Adrian Hunter
2015-02-09T09:48:53Z

On 09/02/15 11:33, Arend van Spriel wrote:
> On 01/29/15 10:00, Adrian Hunter wrote:
>> Check the error code for EOPNOTSUPP and do not print
>> reset warning in that case.
>>
>> Signed-off-by: Adrian Hunter<adrian.hunter@intel.com>
>> ---
>> drivers/mmc/core/core.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>> index 392a150..d439bf0 100644
>> --- a/drivers/mmc/core/core.c
>> +++ b/drivers/mmc/core/core.c
>> @@ -2368,7 +2368,8 @@ int mmc_hw_reset(struct mmc_host *host)
>> ret = host->bus_ops->reset(host);
>> mmc_bus_put(host);
>>
>> - pr_warn("%s: tried to reset card\n", mmc_hostname(host));
>> + if (ret != -EOPNOTSUPP)
>> + pr_warn("%s: tried to reset card\n", mmc_hostname(host));
>
> Guess you don't want this message either if ret is zero.

Thanks for your comment.

I assumed the original author wants to see the message whenever reset is
attempted, which is OK by me because it is on the recovery path i.e.
hopefully rare. The EOPNOTSUPP case is consistent with the code further up
which returns EOPNOTSUPP when there is no ->reset() callback.