From: Joe Perches <joe@perches.com>
To: Sheetal Tigadoli <sheetal.tigadoli@gmail.com>
Cc: chris@printf.net, linux-mmc@vger.kernel.org, ben@decadent.org.uk,
kuninori.morimoto.gx@renesas.com, ulf.hansson@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: mmc: card: Fixing few coding style errors from file block.c
Date: Sat, 31 Jan 2015 10:44:50 -0800 [thread overview]
Message-ID: <1422729890.2682.1.camel@perches.com> (raw)
In-Reply-To: <1422727667-15785-1-git-send-email-sheetal.tigadoli@gmail.com>
On Sat, 2015-01-31 at 23:37 +0530, Sheetal Tigadoli wrote:
> The patch fixes some of the following error/warnings from the file block.c
>
> ./scripts/checkpatch.pl --file --terse drivers/mmc/card/block.c
Hi.
It's a lot easier to review and accept these sorts of
changes if you break them into more discrete patches.
Try bundling all the similar types of changes into
single patches, each doing more or less the same thing.
Something like:
1: line length conversions
btw: Please use checkpatch --strict to make sure that
multi-line statements are aligned appropriately
2: adding removing blank lines and braces position/removals
3: strto -> kstrto conversions
4: else not necessary
5: coalescing split strings
6: include path conversions
Also please use a cover letter when submitting multiple patches.
It makes it easier to ack and apply the whole set.
> drivers/mmc/card/block.c:45: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> drivers/mmc/card/block.c:102: WARNING: line over 80 characters
> drivers/mmc/card/block.c:186: WARNING: Missing a blank line after declarations
> drivers/mmc/card/block.c:238: WARNING: line over 80 characters
> drivers/mmc/card/block.c:251: WARNING: line over 80 characters
> drivers/mmc/card/block.c:279: WARNING: simple_strtoul is obsolete, use kstrtoul instead
> drivers/mmc/card/block.c:280: WARNING: Missing a blank line after declarations
> drivers/mmc/card/block.c:578: WARNING: line over 80 characters
> drivers/mmc/card/block.c:586: WARNING: line over 80 characters
> drivers/mmc/card/block.c:620: WARNING: Missing a blank line after declarations
> drivers/mmc/card/block.c:1209: WARNING: line over 80 characters
> drivers/mmc/card/block.c:1333: WARNING: quoted string split across lines
> drivers/mmc/card/block.c:1720: WARNING: Missing a blank line after declarations
> drivers/mmc/card/block.c:1734: WARNING: braces {} are not necessary for single statement blocks
> drivers/mmc/card/block.c:1881: WARNING: else is not generally useful after a break or return
> drivers/mmc/card/block.c:2019: WARNING: braces {} are not necessary for single statement blocks
> drivers/mmc/card/block.c:2226: WARNING: line over 80 characters
> drivers/mmc/card/block.c:2285: WARNING: line over 80 characters
> drivers/mmc/card/block.c:2362: ERROR: that open brace { should be on the previous line
prev parent reply other threads:[~2015-01-31 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 18:07 [PATCH] drivers: mmc: card: Fixing few coding style errors from file block.c Sheetal Tigadoli
2015-01-31 18:44 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422729890.2682.1.camel@perches.com \
--to=joe@perches.com \
--cc=ben@decadent.org.uk \
--cc=chris@printf.net \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sheetal.tigadoli@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox