public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Sheetal Tigadoli <sheetal.tigadoli@gmail.com>
To: chris@printf.net
Cc: joe@perches.com, linux-mmc@vger.kernel.org, ben@decadent.org.uk,
	kuninori.morimoto.gx@renesas.com, ulf.hansson@linaro.org,
	linux-kernel@vger.kernel.org,
	Sheetal Tigadoli <sheetal.tigadoli@gmail.com>
Subject: [PATCH 1/5] drivers: mmc: card: Fix replaces simple_strtoul func call with kstrtoul
Date: Mon,  2 Feb 2015 01:36:58 +0530	[thread overview]
Message-ID: <1422821222-24079-2-git-send-email-sheetal.tigadoli@gmail.com> (raw)
In-Reply-To: <1422821222-24079-1-git-send-email-sheetal.tigadoli@gmail.com>

This patch fixes following coding style warning in file block.c

        drivers/mmc/card/block.c:279: WARNING: simple_strtoul is obsolete, use kstrtoul instead

Signed-off-by: Sheetal Tigadoli <sheetal.tigadoli@gmail.com>
---
 drivers/mmc/card/block.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index c69afb5..80f7b4b 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -274,13 +274,12 @@ static ssize_t force_ro_store(struct device *dev, struct device_attribute *attr,
 			      const char *buf, size_t count)
 {
 	int ret;
-	char *end;
 	struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
-	unsigned long set = simple_strtoul(buf, &end, 0);
-	if (end == buf) {
-		ret = -EINVAL;
+	unsigned long set;
+
+	ret = kstrtoul(buf, 0, &set);
+	if ((ret == -EINVAL) || (ret == -ERANGE))
 		goto out;
-	}
 
 	set_disk_ro(dev_to_disk(dev), set || md->read_only);
 	ret = count;
-- 
1.7.9.5


  reply	other threads:[~2015-02-01 20:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-01 20:06 [PATCH 0/5] drivers; mmc: card: Sheetal Tigadoli
2015-02-01 20:06 ` Sheetal Tigadoli [this message]
2015-02-01 20:06   ` [PATCH 2/5] drivers: mmc: card: Fixes Missing blank line after variable initialization, coding style warning Sheetal Tigadoli
2015-02-01 20:07     ` [PATCH 3/5] drivers: mmc: card: Fixes WARNING braces are not necessary for single statement Sheetal Tigadoli
2015-02-01 20:07       ` [PATCH 4/5] drivers: mmc: card: Fixed ERROR that open brace should be on the previous line Sheetal Tigadoli
2015-02-01 20:07         ` [PATCH 5/5] drivers: mmc: card: Fixed warning line over 80 characters in file block Sheetal Tigadoli
2015-02-01 20:20     ` [PATCH 2/5] drivers: mmc: card: Fixes Missing blank line after variable initialization, coding style warning Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422821222-24079-2-git-send-email-sheetal.tigadoli@gmail.com \
    --to=sheetal.tigadoli@gmail.com \
    --cc=ben@decadent.org.uk \
    --cc=chris@printf.net \
    --cc=joe@perches.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox