* [PATCH] mmc: sdhci-esdhc-imx: Call mmc_of_parse()
@ 2015-03-12 22:15 Fabio Estevam
2015-03-13 10:15 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2015-03-12 22:15 UTC (permalink / raw)
To: ulf.hansson; +Cc: shawn.guo, linux, kernel, otavio, linux-mmc, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently it is not possible to use 'mmc-pwrseq-simple' property with this
driver because mmc_of_parse() is never called.
mmc_of_parse() calls mmc_pwrseq_alloc() that manages MMC power sequence.
Call the generic mmc_of_parse() so that we can use 'mmc-pwrseq-simple' to
provide reset GPIO to the Wifi/BT chip.
Tested on a imx6sl-warp board.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mmc/host/sdhci-esdhc-imx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 9cce5cf..d714d8f 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -1075,6 +1075,11 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
}
+ /* call to generic mmc_of_parse to support additional capabilities */
+ err = mmc_of_parse(host->mmc);
+ if (err)
+ goto disable_clk;
+
err = sdhci_add_host(host);
if (err)
goto disable_clk;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: sdhci-esdhc-imx: Call mmc_of_parse()
2015-03-12 22:15 [PATCH] mmc: sdhci-esdhc-imx: Call mmc_of_parse() Fabio Estevam
@ 2015-03-13 10:15 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2015-03-13 10:15 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Russell King - ARM Linux, Sascha Hauer,
Otavio Salvador, linux-mmc, Fabio Estevam
On 12 March 2015 at 23:15, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Currently it is not possible to use 'mmc-pwrseq-simple' property with this
> driver because mmc_of_parse() is never called.
>
> mmc_of_parse() calls mmc_pwrseq_alloc() that manages MMC power sequence.
>
> Call the generic mmc_of_parse() so that we can use 'mmc-pwrseq-simple' to
> provide reset GPIO to the Wifi/BT chip.
>
> Tested on a imx6sl-warp board.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Thanks, applied!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 9cce5cf..d714d8f 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1075,6 +1075,11 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
> host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
> }
>
> + /* call to generic mmc_of_parse to support additional capabilities */
> + err = mmc_of_parse(host->mmc);
> + if (err)
> + goto disable_clk;
> +
> err = sdhci_add_host(host);
> if (err)
> goto disable_clk;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-13 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 22:15 [PATCH] mmc: sdhci-esdhc-imx: Call mmc_of_parse() Fabio Estevam
2015-03-13 10:15 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox