Re: [PATCH V6 04/15] mmc: core: Check re-tuning before retrying

Ulf Hansson
2015-05-04T13:30:59Z

On 20 April 2015 at 14:09, Adrian Hunter <adrian.hunter@intel.com> wrote:
> Possibly a command is failing because re-tuning is needed.
> Use mmc_retune_recheck() to check re-tuning. At that point
> re-tuning is held, at least by the request, so
> mmc_retune_recheck() flags host->retune_now if the hold
> count is 1.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

This patch should probably be folded into patch3.

Kind regards
Uffe

> ---
> drivers/mmc/core/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index a9936cb..08bf7e3 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -434,6 +434,7 @@ static int mmc_wait_for_data_req_done(struct mmc_host *host,
> host->areq);
> break; /* return err */
> } else {
> + mmc_retune_recheck(host);
> pr_info("%s: req failed (CMD%u): %d, retrying...\n",
> mmc_hostname(host),
> cmd->opcode, cmd->error);
> @@ -483,6 +484,8 @@ static void mmc_wait_for_req_done(struct mmc_host *host,
> mmc_card_removed(host->card))
> break;
>
> + mmc_retune_recheck(host);
> +
> pr_debug("%s: req failed (CMD%u): %d, retrying...\n",
> mmc_hostname(host), cmd->opcode, cmd->error);
> cmd->retries--;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html