Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

Kevin Hao
2015-05-21T10:56:21Z

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Thu, May 21, 2015 at 09:24:43AM +0000, Joakim Tjernlund wrote:
> The HW 8BIT can be confused with SDHCI_CTRL_HISPD(0x04) as it is the same bit.
>
> However, now I see that esdhc_writeb() has
> /* Prevent SDHCI core from writing reserved bits (e.g. HISPD). */
> if (reg == SDHCI_HOST_CONTROL)
> val &= ~ESDHC_HOST_CONTROL_RES;
> and
> #define ESDHC_HOST_CONTROL_RES 0x05
>
> so any esdhc_writeb() to SDHCI_HOST_CONTROL will clear the HW 8BIT.
> What a mess.

Aha, I see. Thanks for the explanation.

Thanks,
Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]