Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

Kevin Hao
2015-05-15T07:43:05Z

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

On Fri, May 15, 2015 at 07:24:55AM +0000, Joakim Tjernlund wrote:
> Ahh, now I see. Drivers are supposed to call sdhci_set_bus_width instead of NULL:
> Instead of reverting this add:
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 7a98a22..07b9df2 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -283,6 +283,7 @@ static const struct sdhci_ops sdhci_esdhc_ops = {
> .get_min_clock = esdhc_of_get_min_clock,
> .platform_init = esdhc_of_platform_init,
> .adma_workaround = esdhci_of_adma_workaround,
> + .set_bus_width = sdhci_set_bus_width,
> .reset = esdhc_reset,
> .set_uhs_signaling = sdhci_set_uhs_signaling,
> };
>
> Should I repost the full "sdhci-of-esdhc: Support 8BIT bus width." with this fix added
> of just the above fix?

Sorry, this still don't work.

Thanks,
Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]