From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eddie Huang Subject: Re: [PATCH v6 4/7] arm64: dts: mediatek: Add MT8173 MMC dts Date: Thu, 18 Jun 2015 10:04:23 +0800 Message-ID: <1434593063.23303.3.camel@mtksdaap41> References: <1434367253-26577-1-git-send-email-chaotian.jing@mediatek.com> <1434367253-26577-5-git-send-email-chaotian.jing@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Kurtz Cc: Mark Rutland , James Liao , Ulf Hansson , Catalin Marinas , Will Deacon , Chris Ball , Russell King - ARM Linux , Hongzhou Yang , Chaotian Jing , "Joe.C" , "open list:OPEN FIRMWARE AND..." , Arnd Bergmann , bin.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Henry Chen , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , srv_heupstream , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-mmc@vger.kernel.org Hi Dan, On Tue, 2015-06-16 at 20:20 +0800, Daniel Kurtz wrote: > On Tue, Jun 16, 2015 at 7:39 PM, Daniel Kurtz wrote: > > On Mon, Jun 15, 2015 at 7:20 PM, Chaotian Jing > > wrote: > >> From: Eddie Huang > >> > >> Add node mmc0 ~ mmc3 for mt8173.dtsi > >> Add node mmc0, mmc1 for mt8173-evb.dts > >> > >> Signed-off-by: Chaotian Jing > >> Signed-off-by: Eddie Huang > >> --- > >> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 126 ++++++++++++++++++++++++++++ > >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 45 +++++++++- > >> 2 files changed, 170 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > >> index b1560c9..762ec61 100644 > >> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > >> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > >> @@ -33,6 +33,132 @@ > >> chosen { }; > >> }; > >> > >> +&mmc0 { > >> + pinctrl-names = "default", "state_uhs"; > >> + pinctrl-0 = <&mmc0_pins_default>; > >> + pinctrl-1 = <&mmc0_pins_uhs>; > >> + status = "okay"; > >> + bus-width = <8>; > >> + max-frequency = <50000000>; > >> + cap-mmc-highspeed; > >> + vmmc-supply = <&mt6397_vemc_3v3_reg>; > >> + vqmmc-supply = <&mt6397_vio18_reg>; > > I also can't find phandles for these regulators. > > >> + non-removable; > >> +}; > >> + > >> +&mmc1 { > >> + pinctrl-names = "default", "state_uhs"; > >> + pinctrl-0 = <&mmc1_pins_default>; > >> + pinctrl-1 = <&mmc1_pins_uhs>; > >> + status = "okay"; > >> + bus-width = <4>; > >> + max-frequency = <50000000>; > >> + cap-sd-highspeed; > >> + sd-uhs-sdr25; > >> + cd-gpios = <&pio 132 0>; > >> + vmmc-supply = <&mt6397_vmch_reg>; > >> + vqmmc-supply = <&mt6397_vmc_reg>; > > nor these regulators. > > Which kernel branch are you basing your patch set on? > It is based on 4.1-rc1, and Sascha's regulator dts patch. [3/4] ARM: dts: mt8135-evbp1: Add PMIC support: https://patchwork.kernel.org/patch/6261161/ Eddie Thanks