[PATCH v2 0/7] fix build failure of mn10300

[PATCH v2 0/7] fix build failure of mn10300

[Sudip Mukherjee]

Hi,
This is an attempt to fix the build failures when building mn10300 with
allmodconfig. As I have never worked with arch files so I hope you will
point me to right direction to correct my mistakes in this attempt.

regards
sudip

Sudip Mukherjee (7):
  mn10300: fix build failure
  mn10300: Provide dummy dma_alloc_attrs() and dma_free_attrs()
  mmc: mediatek: build as module
  USB: mos7720: rename DCR
  samples: kdbus: disable for mn10300
  mn10300: kgdb_arch_set_pc
  mn10300: add early_init_dt_*

 arch/mn10300/include/asm/dma-mapping.h | 13 +++++++++++++
 arch/mn10300/include/asm/kprobes.h     | 12 ++++++++++++
 arch/mn10300/kernel/kgdb.c             |  5 +++++
 arch/mn10300/kernel/setup.c            | 15 +++++++++++++++
 drivers/mmc/host/mtk-sd.c              |  1 +
 drivers/usb/serial/mos7720.c           | 16 ++++++++--------
 samples/Kconfig                        |  2 +-
 7 files changed, 55 insertions(+), 9 deletions(-)

-- 
1.8.1.2

[PATCH v2 1/7] mn10300: fix build failure

[Sudip Mukherjee]

allmodconfig build fails with the error:
invalid use of undefined type 'struct kprobe_ctlblk'

just declared the two basic structures after checking the struct in other
architectures.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 arch/mn10300/include/asm/kprobes.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/mn10300/include/asm/kprobes.h b/arch/mn10300/include/asm/kprobes.h
index c800b59..c90d2b1 100644
--- a/arch/mn10300/include/asm/kprobes.h
+++ b/arch/mn10300/include/asm/kprobes.h
@@ -47,4 +47,16 @@ extern int kprobe_exceptions_notify(struct notifier_block *self,
 
 extern void arch_remove_kprobe(struct kprobe *p);
 
+struct prev_kprobe {
+	struct kprobe *kp;
+	unsigned long status;
+};
+
+struct kprobe_ctlblk {
+	unsigned int kprobe_status;
+	struct pt_regs jprobe_saved_regs;
+	char jprobes_stack[MAX_STACK_SIZE];
+	struct prev_kprobe prev_kprobe;
+};
+
 #endif /* _ASM_KPROBES_H */
-- 
1.8.1.2

[PATCH v2 3/7] mmc: mediatek: build as module

[Sudip Mukherjee]

while building as module with mn10300 it failed with:

warning: data definition has no type or storage class
	module_init(__driver##_init);

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/mmc/host/mtk-sd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 7c20f28..ea6ae36 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -33,6 +33,7 @@
 #include <linux/mmc/mmc.h>
 #include <linux/mmc/sd.h>
 #include <linux/mmc/sdio.h>
+#include <linux/module.h>
 
 #define MAX_BD_NUM          1024
 
-- 
1.8.1.2

Re: [PATCH v2 3/7] mmc: mediatek: build as module

[Ulf Hansson]

On 18 June 2015 at 14:17, Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> while building as module with mn10300 it failed with:
>
> warning: data definition has no type or storage class
>         module_init(__driver##_init);
>
> Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>

Thanks for the patch. It's although already been fixed on my next branch.

Kind regards
Uffe

> ---
>  drivers/mmc/host/mtk-sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 7c20f28..ea6ae36 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -33,6 +33,7 @@
>  #include <linux/mmc/mmc.h>
>  #include <linux/mmc/sd.h>
>  #include <linux/mmc/sdio.h>
> +#include <linux/module.h>
>
>  #define MAX_BD_NUM          1024
>
> --
> 1.8.1.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 4/7] USB: mos7720: rename DCR

[Sudip Mukherjee]

While building with mn10300 it failed with:
error: expected identifier before '(' token
 #define __SYSREG(ADDR, TYPE) (*(volatile TYPE *)(ADDR))
note: in expansion of macro '__SYSREG'
 #define DCR   __SYSREG(0xc0000030, u16) /* Debug control register */

mn10300 has a register named as DCR, so when this driver used an enum
named as DCR, build failed.
Just rename the DCR in the driver to parport_DCR.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/usb/serial/mos7720.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 4f70df3..3263125 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -135,7 +135,7 @@ enum mos_regs {
 	DLM,
 	DPR,              /* parallel port regs */
 	DSR,
-	DCR,
+	parport_DCR,
 	ECR,
 	SP1_REG,          /* device control regs */
 	SP2_REG,          /* serial port 2 (7720 only) */
@@ -164,7 +164,7 @@ static inline __u16 get_reg_index(enum mos_regs reg)
 		0x01,		/* DLM */
 		0x00,		/* DPR */
 		0x01,		/* DSR */
-		0x02,		/* DCR */
+		0x02,		/* parport_DCR */
 		0x0a,		/* ECR */
 		0x01,		/* SP1_REG */
 		0x02,		/* SP2_REG (7720 only) */
@@ -510,7 +510,7 @@ static void parport_mos7715_write_control(struct parport *pp, unsigned char d)
 	if (parport_prologue(pp) < 0)
 		return;
 	data = ((__u8)d & 0x0f) | (mos_parport->shadowDCR & 0xf0);
-	write_mos_reg(mos_parport->serial, dummy, DCR, data);
+	write_mos_reg(mos_parport->serial, dummy, parport_DCR, data);
 	mos_parport->shadowDCR = data;
 	parport_epilogue(pp);
 }
@@ -543,7 +543,7 @@ static unsigned char parport_mos7715_frob_control(struct parport *pp,
 	if (parport_prologue(pp) < 0)
 		return 0;
 	mos_parport->shadowDCR = (mos_parport->shadowDCR & (~mask)) ^ val;
-	write_mos_reg(mos_parport->serial, dummy, DCR, mos_parport->shadowDCR);
+	write_mos_reg(mos_parport->serial, dummy, parport_DCR, mos_parport->shadowDCR);
 	dcr = mos_parport->shadowDCR & 0x0f;
 	parport_epilogue(pp);
 	return dcr;
@@ -581,7 +581,7 @@ static void parport_mos7715_data_forward(struct parport *pp)
 		return;
 	mos7715_change_mode(mos_parport, PS2);
 	mos_parport->shadowDCR &=  ~0x20;
-	write_mos_reg(mos_parport->serial, dummy, DCR, mos_parport->shadowDCR);
+	write_mos_reg(mos_parport->serial, dummy, parport_DCR, mos_parport->shadowDCR);
 	parport_epilogue(pp);
 }
 
@@ -593,7 +593,7 @@ static void parport_mos7715_data_reverse(struct parport *pp)
 		return;
 	mos7715_change_mode(mos_parport, PS2);
 	mos_parport->shadowDCR |= 0x20;
-	write_mos_reg(mos_parport->serial, dummy, DCR, mos_parport->shadowDCR);
+	write_mos_reg(mos_parport->serial, dummy, parport_DCR, mos_parport->shadowDCR);
 	parport_epilogue(pp);
 }
 
@@ -633,7 +633,7 @@ static void parport_mos7715_restore_state(struct parport *pp,
 		spin_unlock(&release_lock);
 		return;
 	}
-	write_parport_reg_nonblock(mos_parport, DCR, mos_parport->shadowDCR);
+	write_parport_reg_nonblock(mos_parport, parport_DCR, mos_parport->shadowDCR);
 	write_parport_reg_nonblock(mos_parport, ECR, mos_parport->shadowECR);
 	spin_unlock(&release_lock);
 }
@@ -719,7 +719,7 @@ static int mos7715_parport_init(struct usb_serial *serial)
 
 	/* initialize device registers */
 	mos_parport->shadowDCR = DCR_INIT_VAL;
-	write_mos_reg(mos_parport->serial, dummy, DCR, mos_parport->shadowDCR);
+	write_mos_reg(mos_parport->serial, dummy, parport_DCR, mos_parport->shadowDCR);
 	mos_parport->shadowECR = ECR_INIT_VAL;
 	write_mos_reg(mos_parport->serial, dummy, ECR, mos_parport->shadowECR);
 
-- 
1.8.1.2

Re: [PATCH v2 4/7] USB: mos7720: rename DCR

[Johan Hovold]

On Thu, Jun 18, 2015 at 05:47:50PM +0530, Sudip Mukherjee wrote:
> While building with mn10300 it failed with:
> error: expected identifier before '(' token
>  #define __SYSREG(ADDR, TYPE) (*(volatile TYPE *)(ADDR))
> note: in expansion of macro '__SYSREG'
>  #define DCR   __SYSREG(0xc0000030, u16) /* Debug control register */
> 
> mn10300 has a register named as DCR, so when this driver used an enum
> named as DCR, build failed.
> Just rename the DCR in the driver to parport_DCR.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/usb/serial/mos7720.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 4f70df3..3263125 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -135,7 +135,7 @@ enum mos_regs {
>  	DLM,
>  	DPR,              /* parallel port regs */
>  	DSR,
> -	DCR,
> +	parport_DCR,
>  	ECR,
>  	SP1_REG,          /* device control regs */
>  	SP2_REG,          /* serial port 2 (7720 only) */

Please use a MOS_ (or MOS7720_) prefix instead and add it to all the
registers.

Thanks,
Johan

[PATCH v2 5/7] samples: kdbus: disable for mn10300

[Sudip Mukherjee]

While building it failed with:
In function 'prime_new':
error: '__NR_memfd_create' undeclared (first use in this function)

memfd_create syscall has not yet been implemented for mn10300.
so disable compilation of samples/kdbus for now with mn10300.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 samples/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/Kconfig b/samples/Kconfig
index a4c6b2f..20c55af 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -57,7 +57,7 @@ config SAMPLE_KDB
 
 config SAMPLE_KDBUS
 	bool "Build kdbus API example"
-	depends on KDBUS
+	depends on KDBUS && !MN10300
 	help
 	  Build an example of how the kdbus API can be used from
 	  userspace.
-- 
1.8.1.2

Re: [PATCH v2 5/7] samples: kdbus: disable for mn10300

[Greg Kroah-Hartman]

On Thu, Jun 18, 2015 at 05:47:51PM +0530, Sudip Mukherjee wrote:
> While building it failed with:
> In function 'prime_new':
> error: '__NR_memfd_create' undeclared (first use in this function)
> 
> memfd_create syscall has not yet been implemented for mn10300.
> so disable compilation of samples/kdbus for now with mn10300.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  samples/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/Kconfig b/samples/Kconfig
> index a4c6b2f..20c55af 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -57,7 +57,7 @@ config SAMPLE_KDB
>  
>  config SAMPLE_KDBUS
>  	bool "Build kdbus API example"
> -	depends on KDBUS
> +	depends on KDBUS && !MN10300

Why not just add the memfd syscall to this arch?  I thought someone had
already sent such a patch in a while ago.

thanks,

greg k-h

Re: [PATCH v2 5/7] samples: kdbus: disable for mn10300

[Sudip Mukherjee]

On Thu, Jun 18, 2015 at 07:39:58AM -0700, Greg Kroah-Hartman wrote:
> On Thu, Jun 18, 2015 at 05:47:51PM +0530, Sudip Mukherjee wrote:
> > While building it failed with:
> > In function 'prime_new':
> > error: '__NR_memfd_create' undeclared (first use in this function)
> > 
> > memfd_create syscall has not yet been implemented for mn10300.
> > so disable compilation of samples/kdbus for now with mn10300.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
> > ---
> >  samples/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/samples/Kconfig b/samples/Kconfig
> > index a4c6b2f..20c55af 100644
> > --- a/samples/Kconfig
> > +++ b/samples/Kconfig
> > @@ -57,7 +57,7 @@ config SAMPLE_KDB
> >  
> >  config SAMPLE_KDBUS
> >  	bool "Build kdbus API example"
> > -	depends on KDBUS
> > +	depends on KDBUS && !MN10300
> 
> Why not just add the memfd syscall to this arch?
Yes, I intend to. But for now this will fix allmodconfig.
>I thought someone had already sent such a patch in a while ago.
Then it is still not merged. :(
I will try to find that patch adding memfd syscall. And if i find it whom
shall I forward it to?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 5/7] samples: kdbus: disable for mn10300

[Greg Kroah-Hartman]

On Thu, Jun 18, 2015 at 09:49:05PM +0530, Sudip Mukherjee wrote:
> On Thu, Jun 18, 2015 at 07:39:58AM -0700, Greg Kroah-Hartman wrote:
> > On Thu, Jun 18, 2015 at 05:47:51PM +0530, Sudip Mukherjee wrote:
> > > While building it failed with:
> > > In function 'prime_new':
> > > error: '__NR_memfd_create' undeclared (first use in this function)
> > > 
> > > memfd_create syscall has not yet been implemented for mn10300.
> > > so disable compilation of samples/kdbus for now with mn10300.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > ---
> > >  samples/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/samples/Kconfig b/samples/Kconfig
> > > index a4c6b2f..20c55af 100644
> > > --- a/samples/Kconfig
> > > +++ b/samples/Kconfig
> > > @@ -57,7 +57,7 @@ config SAMPLE_KDB
> > >  
> > >  config SAMPLE_KDBUS
> > >  	bool "Build kdbus API example"
> > > -	depends on KDBUS
> > > +	depends on KDBUS && !MN10300
> > 
> > Why not just add the memfd syscall to this arch?
> Yes, I intend to. But for now this will fix allmodconfig.
> >I thought someone had already sent such a patch in a while ago.
> Then it is still not merged. :(
> I will try to find that patch adding memfd syscall. And if i find it whom
> shall I forward it to?

The maintainers of this arch.

[PATCH v2 6/7] mn10300: kgdb_arch_set_pc

[Sudip Mukherjee]

While building it failed with:
undefined reference to `kgdb_arch_set_pc'

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 arch/mn10300/kernel/kgdb.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/mn10300/kernel/kgdb.c b/arch/mn10300/kernel/kgdb.c
index 9977082..8a0ae2b 100644
--- a/arch/mn10300/kernel/kgdb.c
+++ b/arch/mn10300/kernel/kgdb.c
@@ -499,3 +499,8 @@ void kgdb_roundup_cpus(unsigned long flags)
 	smp_jump_to_debugger();
 }
 #endif
+
+void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip)
+{
+	regs->pc = ip;
+}
-- 
1.8.1.2

[PATCH v2 2/7] mn10300: Provide dummy dma_alloc_attrs() and dma_free_attrs()

[Sudip Mukherjee]

allmodconfig fails to build with following errors.

drivers/media/platform/sti/bdisp/bdisp-hw.c:
	In function 'bdisp_hw_free_nodes':
drivers/media/platform/sti/bdisp/bdisp-hw.c:132:3: error:
	implicit declaration of function 'dma_free_attrs'

drivers/media/platform/sti/bdisp/bdisp-hw.c:
	In function 'bdisp_hw_alloc_nodes':
drivers/media/platform/sti/bdisp/bdisp-hw.c:157:2: error:
	implicit declaration of function 'dma_alloc_attrs'

mn10300 does not provide those functions at this time.
Provide dummy implementations to avoid build errors.

Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
---

copied from https://lkml.org/lkml/2015/4/22/346

 arch/mn10300/include/asm/dma-mapping.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/mn10300/include/asm/dma-mapping.h b/arch/mn10300/include/asm/dma-mapping.h
index a18abfc..d589c5e 100644
--- a/arch/mn10300/include/asm/dma-mapping.h
+++ b/arch/mn10300/include/asm/dma-mapping.h
@@ -183,4 +183,17 @@ static inline int dma_get_sgtable(struct device *dev, struct sg_table *sgt,
 	return -EINVAL;
 }
 
+static inline void *dma_alloc_attrs(struct device *dev, size_t size,
+				    dma_addr_t *dma_handle, gfp_t flag,
+				    struct dma_attrs *attrs)
+{
+	return NULL;
+}
+
+static inline void dma_free_attrs(struct device *dev, size_t size,
+				  void *vaddr, dma_addr_t dma_handle,
+				  struct dma_attrs *attrs)
+{
+}
+
 #endif
-- 
1.8.1.2

[PATCH v2 7/7] mn10300: add early_init_dt_*

[Sudip Mukherjee]

While building it failed with:
undefined reference to `early_init_dt_alloc_memory_arch'
undefined reference to `early_init_dt_add_memory_arch'

Added the function after seeing them in x86.

Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
---
 arch/mn10300/kernel/setup.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/mn10300/kernel/setup.c b/arch/mn10300/kernel/setup.c
index 2ad7f32..f0e08b0 100644
--- a/arch/mn10300/kernel/setup.c
+++ b/arch/mn10300/kernel/setup.c
@@ -87,6 +87,21 @@ static int __init early_mem(char *p)
 early_param("mem", early_mem);
 
 /*
+ * early_init_dt_add_memory_arch() and early_init_dt_alloc_memory_arch()
+ * borrowed from arch/x86/kernel/devicetree.c
+ */
+
+void __init early_init_dt_add_memory_arch(u64 base, u64 size)
+{
+	BUG();
+}
+
+void * __init early_init_dt_alloc_memory_arch(u64 size, u64 align)
+{
+	return __alloc_bootmem(size, align, 0);
+}
+
+/*
  * architecture specific setup
  */
 void __init setup_arch(char **cmdline_p)
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/7] fix build failure of mn10300

[Russell King - ARM Linux]

On Thu, Jun 18, 2015 at 05:47:46PM +0530, Sudip Mukherjee wrote:
> This is an attempt to fix the build failures when building mn10300 with
> allmodconfig. As I have never worked with arch files so I hope you will
> point me to right direction to correct my mistakes in this attempt.

Why has the linux-arm-kernel mailing list been copied for something
which clearly has nothing to do with ARM?  Am I missing something
in this series?

(Or is there a competition on to see who can add as many entries in
the Cc without getting caught by any filtering? :) )

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

Re: [Linux-am33-list] [PATCH v2 0/7] fix build failure of mn10300

[Russell King - ARM Linux]

On Thu, Jun 18, 2015 at 10:31:07AM -0500, Jay C. Polmar wrote:
> I am on this list by mistake and 5/15/2011 we requested to be removed,
> can someone remove me from this list?

There are six mailing lists in the Cc line.  For all of the lists
present there, I can't help you, but you should be able to unsubscribe
yourself.  Look at the footer on any message you receive from the list
and it should tell you how to get more information on that subject.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/7] fix build failure of mn10300

[Sudip Mukherjee]

On Thu, Jun 18, 2015 at 03:51:38PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 18, 2015 at 05:47:46PM +0530, Sudip Mukherjee wrote:
> > This is an attempt to fix the build failures when building mn10300 with
> > allmodconfig. As I have never worked with arch files so I hope you will
> > point me to right direction to correct my mistakes in this attempt.
> 
> Why has the linux-arm-kernel mailing list been copied for something
> which clearly has nothing to do with ARM?  Am I missing something
> in this series?
get_maintainer.pl is giving linux-arm-kernel mailing list for
patch 3/7 ("mmc: mediatek: build as module").

regards
sudip