From: Joe Perches <joe@perches.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: ulf.hansson@linaro.org, Nicholas Krause <xerofoify@gmail.com>,
ben.dooks@codethink.co.uk, ykaneko0929@gmail.com,
laurent.pinchart+renesas@ideasonboard.com,
kouichi.tomita.yn@renesas.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma_one
Date: Tue, 23 Jun 2015 17:07:24 -0700 [thread overview]
Message-ID: <1435104444.2504.28.camel@perches.com> (raw)
In-Reply-To: <87r3p2rnek.wl%kuninori.morimoto.gx@renesas.com>
On Wed, 2015-06-24 at 08:54 +0900, Kuninori Morimoto wrote:
> Can you please teach us about status of this patch ?
> > This adds a cast to the variables,slave_id_rx and slave_id_rx
> > to uintptr_t before casting to void* in order to avoid build
> > warning on 64bit platforms for the function, sh_mmcif_request_dma_one.
[]
> > diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
[]
> > @@ -398,8 +398,8 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host,
> >
> > if (pdata)
> > slave_data = direction == DMA_MEM_TO_DEV ?
> > - (void *)pdata->slave_id_tx :
> > - (void *)pdata->slave_id_rx;
> > + (void *)(uintptr_t)pdata->slave_id_tx :
> > + (void *)(uintptr_t)pdata->slave_id_rx;
It's far more common (~10:1) in the kernel to cast using
(<type> *)(unsigned long)<foo>
than
(<type> *)(uintptr_t)<foo>
next prev parent reply other threads:[~2015-06-24 0:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1431366550-22045-1-git-send-email-xerofoify@gmail.com>
2015-05-12 0:18 ` [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma_one Kuninori Morimoto
2015-06-23 23:54 ` Kuninori Morimoto
2015-06-24 0:07 ` Joe Perches [this message]
[not found] ` <5589F6D8.5090107@gmail.com>
2015-06-24 0:24 ` Kuninori Morimoto
2015-06-24 0:40 ` Joe Perches
[not found] ` <5589FD65.7040807@gmail.com>
2015-06-24 0:54 ` Joe Perches
2015-06-24 7:16 ` Arnd Bergmann
[not found] ` <55953D85.3000507@gmail.com>
2015-07-20 14:21 ` Ulf Hansson
[not found] ` <55AD07E6.1060209@gmail.com>
2015-07-21 7:41 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435104444.2504.28.camel@perches.com \
--to=joe@perches.com \
--cc=ben.dooks@codethink.co.uk \
--cc=kouichi.tomita.yn@renesas.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xerofoify@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox