* [PATCH 1/1] mmc: block: don't use parameter prefix if built as module
@ 2015-06-24 11:32 Andy Shevchenko
2015-07-06 12:23 ` Andy Shevchenko
2015-07-20 14:21 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2015-06-24 11:32 UTC (permalink / raw)
To: Ulf Hansson, Adrian Hunter, linux-mmc; +Cc: Andy Shevchenko
It's excessive to use prefix for the parameters when you do
modrpobe mmc-block mmcblk.perdev_minors=16
Make this available only for built-in case.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mmc/card/block.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index c9c3d20..b94540b 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -47,10 +47,13 @@
#include "queue.h"
MODULE_ALIAS("mmc:block");
+
+#ifdef KERNEL
#ifdef MODULE_PARAM_PREFIX
#undef MODULE_PARAM_PREFIX
#endif
#define MODULE_PARAM_PREFIX "mmcblk."
+#endif
#define INAND_CMD38_ARG_EXT_CSD 113
#define INAND_CMD38_ARG_ERASE 0x00
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mmc: block: don't use parameter prefix if built as module
2015-06-24 11:32 [PATCH 1/1] mmc: block: don't use parameter prefix if built as module Andy Shevchenko
@ 2015-07-06 12:23 ` Andy Shevchenko
2015-07-20 14:21 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2015-07-06 12:23 UTC (permalink / raw)
To: Ulf Hansson, Adrian Hunter, linux-mmc
On Wed, 2015-06-24 at 14:32 +0300, Andy Shevchenko wrote:
> It's excessive to use prefix for the parameters when you do
> modrpobe mmc-block mmcblk.perdev_minors=16
>
> Make this available only for built-in case.
Any comments on this?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mmc/card/block.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index c9c3d20..b94540b 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -47,10 +47,13 @@
> #include "queue.h"
>
> MODULE_ALIAS("mmc:block");
> +
> +#ifdef KERNEL
> #ifdef MODULE_PARAM_PREFIX
> #undef MODULE_PARAM_PREFIX
> #endif
> #define MODULE_PARAM_PREFIX "mmcblk."
> +#endif
>
> #define INAND_CMD38_ARG_EXT_CSD 113
> #define INAND_CMD38_ARG_ERASE 0x00
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mmc: block: don't use parameter prefix if built as module
2015-06-24 11:32 [PATCH 1/1] mmc: block: don't use parameter prefix if built as module Andy Shevchenko
2015-07-06 12:23 ` Andy Shevchenko
@ 2015-07-20 14:21 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2015-07-20 14:21 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Adrian Hunter, linux-mmc
On 24 June 2015 at 13:32, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> It's excessive to use prefix for the parameters when you do
> modrpobe mmc-block mmcblk.perdev_minors=16
>
> Make this available only for built-in case.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks, applied!
Kind regards
Uffe
> ---
> drivers/mmc/card/block.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index c9c3d20..b94540b 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -47,10 +47,13 @@
> #include "queue.h"
>
> MODULE_ALIAS("mmc:block");
> +
> +#ifdef KERNEL
> #ifdef MODULE_PARAM_PREFIX
> #undef MODULE_PARAM_PREFIX
> #endif
> #define MODULE_PARAM_PREFIX "mmcblk."
> +#endif
>
> #define INAND_CMD38_ARG_EXT_CSD 113
> #define INAND_CMD38_ARG_ERASE 0x00
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-20 14:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-24 11:32 [PATCH 1/1] mmc: block: don't use parameter prefix if built as module Andy Shevchenko
2015-07-06 12:23 ` Andy Shevchenko
2015-07-20 14:21 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).