linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mmc: MMC_MTK should depend on HAS_DMA
@ 2015-06-26 12:09 Geert Uytterhoeven
  2015-07-20 14:21 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-06-26 12:09 UTC (permalink / raw)
  To: Ulf Hansson, Chaotian Jing; +Cc: linux-mmc, linux-kernel, Geert Uytterhoeven

If NO_DMA=y:

    ERROR: "dma_alloc_coherent" [drivers/mmc/host/mtk-sd.ko] undefined!
    ERROR: "dma_unmap_sg" [drivers/mmc/host/mtk-sd.ko] undefined!
    ERROR: "dma_map_sg" [drivers/mmc/host/mtk-sd.ko] undefined!
    ERROR: "dma_free_coherent" [drivers/mmc/host/mtk-sd.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/mmc/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index fd9a58e216a50ffd..6a0f9c79be2652bd 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -779,6 +779,7 @@ config MMC_TOSHIBA_PCI
 
 config MMC_MTK
 	tristate "MediaTek SD/MMC Card Interface support"
+	depends on HAS_DMA
 	help
 	  This selects the MediaTek(R) Secure digital and Multimedia card Interface.
 	  If you have a machine with a integrated SD/MMC card reader, say Y or M here.
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmc: MMC_MTK should depend on HAS_DMA
  2015-06-26 12:09 [PATCH] mmc: MMC_MTK should depend on HAS_DMA Geert Uytterhoeven
@ 2015-07-20 14:21 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2015-07-20 14:21 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Chaotian Jing, linux-mmc, linux-kernel@vger.kernel.org

On 26 June 2015 at 14:09, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> If NO_DMA=y:
>
>     ERROR: "dma_alloc_coherent" [drivers/mmc/host/mtk-sd.ko] undefined!
>     ERROR: "dma_unmap_sg" [drivers/mmc/host/mtk-sd.ko] undefined!
>     ERROR: "dma_map_sg" [drivers/mmc/host/mtk-sd.ko] undefined!
>     ERROR: "dma_free_coherent" [drivers/mmc/host/mtk-sd.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks, applied for fixes.

Kind regards
Uffe

> ---
>  drivers/mmc/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index fd9a58e216a50ffd..6a0f9c79be2652bd 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -779,6 +779,7 @@ config MMC_TOSHIBA_PCI
>
>  config MMC_MTK
>         tristate "MediaTek SD/MMC Card Interface support"
> +       depends on HAS_DMA
>         help
>           This selects the MediaTek(R) Secure digital and Multimedia card Interface.
>           If you have a machine with a integrated SD/MMC card reader, say Y or M here.
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-20 14:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-26 12:09 [PATCH] mmc: MMC_MTK should depend on HAS_DMA Geert Uytterhoeven
2015-07-20 14:21 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).