From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/1] mmc: block: don't use parameter prefix if built as module
Date: Mon, 06 Jul 2015 15:23:23 +0300 [thread overview]
Message-ID: <1436185403.10819.0.camel@linux.intel.com> (raw)
In-Reply-To: <1435145541-127393-1-git-send-email-andriy.shevchenko@linux.intel.com>
On Wed, 2015-06-24 at 14:32 +0300, Andy Shevchenko wrote:
> It's excessive to use prefix for the parameters when you do
> modrpobe mmc-block mmcblk.perdev_minors=16
>
> Make this available only for built-in case.
Any comments on this?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mmc/card/block.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index c9c3d20..b94540b 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -47,10 +47,13 @@
> #include "queue.h"
>
> MODULE_ALIAS("mmc:block");
> +
> +#ifdef KERNEL
> #ifdef MODULE_PARAM_PREFIX
> #undef MODULE_PARAM_PREFIX
> #endif
> #define MODULE_PARAM_PREFIX "mmcblk."
> +#endif
>
> #define INAND_CMD38_ARG_EXT_CSD 113
> #define INAND_CMD38_ARG_ERASE 0x00
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-07-06 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 11:32 [PATCH 1/1] mmc: block: don't use parameter prefix if built as module Andy Shevchenko
2015-07-06 12:23 ` Andy Shevchenko [this message]
2015-07-20 14:21 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436185403.10819.0.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).