From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"haokexin@gmail.com" <haokexin@gmail.com>
Subject: Re: [PATCH] sdhci-esdhc: Make 8BIT bus work.
Date: Wed, 22 Jul 2015 12:32:29 +0000 [thread overview]
Message-ID: <1437568349.10831.99.camel@transmode.se> (raw)
In-Reply-To: <CAPDyKFpzMrzoY3xDHsMTwOUk0Xkp1d-cY_UW7U0EEfoYQakU0A@mail.gmail.com>
On Wed, 2015-07-22 at 14:18 +0200, Ulf Hansson wrote:
> On 20 July 2015 at 18:19, Joakim Tjernlund
> <joakim.tjernlund@transmode.se> wrote:
> > Support for 8BIT bus with was added some time ago to sdhci-esdhc but
> > then missed to remove the 8BIT from the reserved bit mask which made
> > 8BIT non functional.
> >
> > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
>
> Should this be queued as a fix then? If so, please resend and include
> a fixes tag.
8BIT never worked for this controller, when support for 8BIT was added no one
noticed that it didn't work for sdhci-esdhc. I suspect it was never tested.
If that qualifies as a fix I can add an:
Fixes: 66b50a00992d ("mmc: esdhc: Add support for 8-bit bus width and non-removable card")
>
> Kind regards
> Uffe
>
> > ---
> > drivers/mmc/host/sdhci-esdhc.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h
> > index 3497cfa..a870c42 100644
> > --- a/drivers/mmc/host/sdhci-esdhc.h
> > +++ b/drivers/mmc/host/sdhci-esdhc.h
> > @@ -45,6 +45,6 @@
> > #define ESDHC_DMA_SYSCTL 0x40c
> > #define ESDHC_DMA_SNOOP 0x00000040
> >
> > -#define ESDHC_HOST_CONTROL_RES 0x05
> > +#define ESDHC_HOST_CONTROL_RES 0x01
> >
> > #endif /* _DRIVERS_MMC_SDHCI_ESDHC_H */
> > --
> > 2.3.6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-07-22 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 16:19 [PATCH] sdhci-esdhc: Make 8BIT bus work Joakim Tjernlund
2015-07-22 12:18 ` Ulf Hansson
2015-07-22 12:32 ` Joakim Tjernlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437568349.10831.99.camel@transmode.se \
--to=joakim.tjernlund@transmode.se \
--cc=haokexin@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).