linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Initial signal voltage ?
Date: Mon, 10 Aug 2015 16:50:38 +0000	[thread overview]
Message-ID: <1439225438.3120.94.camel@transmode.se> (raw)

in mmc_power_up() we have:
	/* Try to set signal voltage to 3.3V but fall back to 1.8v or 1.2v */
	if (__mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_330) == 0)
		dev_err(mmc_dev(host), "Initial signal voltage of 3.3v\n");
	else if (__mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_180) == 0)
		dev_err(mmc_dev(host), "Initial signal voltage of 1.8v\n");
	else if (__mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_120) == 0)
		dev_err(mmc_dev(host), "Initial signal voltage of 1.2v\n");

Here one jut brutally tries to set the initial power to 3.3 but nowhere in
general code there is a check if the controller can handle this w.r.t
HOST CAPS.
Where should this check be performed, I am guessing either here or in sdhci?
This is all new to me so I am just throwing this out there

 Jocke

             reply	other threads:[~2015-08-10 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 16:50 Joakim Tjernlund [this message]
2015-08-25 12:05 ` Initial signal voltage ? Ulf Hansson
2015-08-25 12:20   ` Joakim Tjernlund
2015-08-27 14:01     ` Ulf Hansson
2015-08-27 14:33       ` Joakim Tjernlund
2015-08-27 14:44         ` Ulf Hansson
2015-08-27 17:16           ` Joakim Tjernlund
2015-09-15 17:43             ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439225438.3120.94.camel@transmode.se \
    --to=joakim.tjernlund@transmode.se \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).