From: Rabin Vincent <rabin.vincent@axis.com>
To: ulf.hansson@linaro.org
Cc: g.liakhovetski@gmx.de, linux-mmc@vger.kernel.org,
Rabin Vincent <rabinv@axis.com>
Subject: [PATCH 3/3] mmc: usdhi6rol0: fix ack register write
Date: Wed, 19 Aug 2015 15:41:36 +0200 [thread overview]
Message-ID: <1439991696-28488-3-git-send-email-rabin.vincent@axis.com> (raw)
In-Reply-To: <1439991696-28488-1-git-send-email-rabin.vincent@axis.com>
The intent appears to be to clear only the bits which are set in status
(by setting them to zero in the ack write), like in the other interrupt
handlers, and not to always clear everything (by always writing zero).
Use the correct not operator.
Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
---
drivers/mmc/host/usdhi6rol0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
index 4188e84e..b505cbc2 100644
--- a/drivers/mmc/host/usdhi6rol0.c
+++ b/drivers/mmc/host/usdhi6rol0.c
@@ -1611,7 +1611,7 @@ static irqreturn_t usdhi6_cd(int irq, void *dev_id)
return IRQ_NONE;
/* Ack */
- usdhi6_write(host, USDHI6_SD_INFO1, !status);
+ usdhi6_write(host, USDHI6_SD_INFO1, ~status);
if (!work_pending(&mmc->detect.work) &&
(((status & USDHI6_SD_INFO1_CARD_INSERT) &&
--
1.7.10.4
next prev parent reply other threads:[~2015-08-19 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 13:41 [PATCH 1/3] mmc: usdhi6rol0: handle probe deferral for regulator Rabin Vincent
2015-08-19 13:41 ` [PATCH 2/3] mmc: usdhi6rol0: fix NULL pointer deref in debug print Rabin Vincent
2015-08-25 12:07 ` Ulf Hansson
2015-08-19 13:41 ` Rabin Vincent [this message]
2015-08-25 12:07 ` [PATCH 3/3] mmc: usdhi6rol0: fix ack register write Ulf Hansson
2015-08-25 12:07 ` [PATCH 1/3] mmc: usdhi6rol0: handle probe deferral for regulator Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439991696-28488-3-git-send-email-rabin.vincent@axis.com \
--to=rabin.vincent@axis.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=rabinv@axis.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox