From: Kishon Vijay Abraham I <kishon@ti.com>
To: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, nsekhar@ti.com
Cc: adrian.hunter@intel.com, neilb@suse.de,
zhonghui.fu@linux.intel.com, afenkart@gmail.com, kishon@ti.com
Subject: [RFC PATCH 1/2] mmc: core: sdio: move mmc_sdio_init_card to a separate function
Date: Mon, 24 Aug 2015 15:45:16 +0530 [thread overview]
Message-ID: <1440411317-8813-1-git-send-email-kishon@ti.com> (raw)
No functional change. Move mmc_sdio_init_card to a separate
function (_mmc_sdio_power_restore) and invoke it from
mmc_sdio_power_restore. This is in preparation to invoke
_mmc_sdio_power_restore from mmc_sdio_runtime_resume so that
mmc_claim_host can be invoked before mmc_power_up.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/mmc/core/sdio.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index b91abed..0cbbfb8 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -970,15 +970,10 @@ static int mmc_sdio_resume(struct mmc_host *host)
return err;
}
-static int mmc_sdio_power_restore(struct mmc_host *host)
+static int _mmc_sdio_power_restore(struct mmc_host *host)
{
int ret;
- BUG_ON(!host);
- BUG_ON(!host->card);
-
- mmc_claim_host(host);
-
/*
* Reset the card by performing the same steps that are taken by
* mmc_rescan_try_freq() and mmc_attach_sdio() during a "normal" probe.
@@ -1002,14 +997,25 @@ static int mmc_sdio_power_restore(struct mmc_host *host)
ret = mmc_send_io_op_cond(host, 0, NULL);
if (ret)
- goto out;
+ return ret;
ret = mmc_sdio_init_card(host, host->card->ocr, host->card,
mmc_card_keep_power(host));
if (!ret && host->sdio_irqs)
mmc_signal_sdio_irq(host);
-out:
+ return 0;
+}
+
+static int mmc_sdio_power_restore(struct mmc_host *host)
+{
+ int ret;
+
+ BUG_ON(!host);
+ BUG_ON(!host->card);
+
+ mmc_claim_host(host);
+ ret = _mmc_sdio_power_restore(host);
mmc_release_host(host);
return ret;
--
1.7.9.5
next reply other threads:[~2015-08-24 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 10:15 Kishon Vijay Abraham I [this message]
2015-08-24 10:15 ` [RFC PATCH 2/2] mmc: core: sdio: claim host before power up or power off Kishon Vijay Abraham I
2015-09-11 12:45 ` Ulf Hansson
2015-09-11 13:17 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440411317-8813-1-git-send-email-kishon@ti.com \
--to=kishon@ti.com \
--cc=adrian.hunter@intel.com \
--cc=afenkart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nsekhar@ti.com \
--cc=ulf.hansson@linaro.org \
--cc=zhonghui.fu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).