From: Yousong Zhou <yszhou4tech@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
linux-mmc@vger.kernel.org, Yousong Zhou <yszhou4tech@gmail.com>
Subject: [PATCH 2/3] mmc: sd: Allow calling sd mode switch with retries
Date: Thu, 10 Sep 2015 00:33:17 +0800 [thread overview]
Message-ID: <1441816398-4330-2-git-send-email-yszhou4tech@gmail.com> (raw)
In-Reply-To: <1441816398-4330-1-git-send-email-yszhou4tech@gmail.com>
This will allow retrying access mode switch to High-Speed in the
following commit.
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
---
drivers/mmc/core/core.c | 4 ++++
drivers/mmc/core/sd_ops.c | 5 +++--
drivers/mmc/core/sd_ops.h | 10 ++++++++--
3 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 9ad73f3..e726bb1 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -468,11 +468,13 @@ static void mmc_wait_for_req_done(struct mmc_host *host,
struct mmc_request *mrq)
{
struct mmc_command *cmd;
+ struct mmc_data *data;
while (1) {
wait_for_completion(&mrq->completion);
cmd = mrq->cmd;
+ data = mrq->data;
/*
* If host has timed out waiting for the sanitize
@@ -501,6 +503,8 @@ static void mmc_wait_for_req_done(struct mmc_host *host,
mmc_hostname(host), cmd->opcode, cmd->error);
cmd->retries--;
cmd->error = 0;
+ if (data)
+ data->error = 0;
__mmc_start_request(host, mrq);
}
diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
index 48d0c93..22bef3c 100644
--- a/drivers/mmc/core/sd_ops.c
+++ b/drivers/mmc/core/sd_ops.c
@@ -304,8 +304,8 @@ int mmc_app_send_scr(struct mmc_card *card, u32 *scr)
return 0;
}
-int mmc_sd_switch(struct mmc_card *card, int mode, int group,
- u8 value, u8 *resp)
+int __mmc_sd_switch(struct mmc_card *card, int mode, int group,
+ u8 value, u8 *resp, int retries)
{
struct mmc_request mrq = {NULL};
struct mmc_command cmd = {0};
@@ -328,6 +328,7 @@ int mmc_sd_switch(struct mmc_card *card, int mode, int group,
cmd.arg &= ~(0xF << (group * 4));
cmd.arg |= value << (group * 4);
cmd.flags = MMC_RSP_SPI_R1 | MMC_RSP_R1 | MMC_CMD_ADTC;
+ cmd.retries = retries;
data.blksz = 64;
data.blocks = 1;
diff --git a/drivers/mmc/core/sd_ops.h b/drivers/mmc/core/sd_ops.h
index ffc2305..a53c51e 100644
--- a/drivers/mmc/core/sd_ops.h
+++ b/drivers/mmc/core/sd_ops.h
@@ -17,9 +17,15 @@ int mmc_send_app_op_cond(struct mmc_host *host, u32 ocr, u32 *rocr);
int mmc_send_if_cond(struct mmc_host *host, u32 ocr);
int mmc_send_relative_addr(struct mmc_host *host, unsigned int *rca);
int mmc_app_send_scr(struct mmc_card *card, u32 *scr);
-int mmc_sd_switch(struct mmc_card *card, int mode, int group,
- u8 value, u8 *resp);
int mmc_app_sd_status(struct mmc_card *card, void *ssr);
+int __mmc_sd_switch(struct mmc_card *card, int mode, int group,
+ u8 value, u8 *resp, int retries);
+static inline int mmc_sd_switch(struct mmc_card *card, int mode, int group,
+ u8 value, u8 *resp)
+{
+ return __mmc_sd_switch(card, mode, group, value, resp, 0);
+}
+
#endif
--
1.7.10.4
next prev parent reply other threads:[~2015-09-09 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 16:33 [PATCH 1/3] mmc: sd: Remove superfluous error code assignment Yousong Zhou
2015-09-09 16:33 ` Yousong Zhou [this message]
2015-09-10 0:33 ` [PATCH 2/3] mmc: sd: Allow calling sd mode switch with retries Shawn Lin
2015-09-10 3:02 ` Yousong Zhou
2015-09-16 2:36 ` Jaehoon Chung
2015-09-16 3:09 ` Yousong Zhou
2015-09-16 4:17 ` Jaehoon Chung
2015-09-17 8:29 ` Yousong Zhou
2015-09-09 16:33 ` [PATCH 3/3] mmc: sd: Retry switching to highspeed mode in case of error Yousong Zhou
2015-09-09 19:29 ` [PATCH 1/3] mmc: sd: Remove superfluous error code assignment Hans de Goede
2015-09-15 11:34 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441816398-4330-2-git-send-email-yszhou4tech@gmail.com \
--to=yszhou4tech@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).