linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [v2] mmc: sdhci-pltfm: enable interrupt mode to detect card for ls1021a
@ 2015-09-16  6:36 Yangbo Lu
  2015-09-23 21:42 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: Yangbo Lu @ 2015-09-16  6:36 UTC (permalink / raw)
  To: linux-mmc, ulf.hansson; +Cc: Yangbo Lu

Enable interrupt mode to detect card instead of polling mode for
ls1021a by removing the quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION.
This could improve data transferring performance and avoid the call
trace caused by polling card status sometime.

Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com>
---
Changes for v2:
	- Modified commit message
---
 drivers/mmc/host/sdhci-of-esdhc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
index 653f335..2a54dbe 100644
--- a/drivers/mmc/host/sdhci-of-esdhc.c
+++ b/drivers/mmc/host/sdhci-of-esdhc.c
@@ -371,7 +371,8 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
 	    of_device_is_compatible(np, "fsl,p5020-esdhc") ||
 	    of_device_is_compatible(np, "fsl,p4080-esdhc") ||
 	    of_device_is_compatible(np, "fsl,p1020-esdhc") ||
-	    of_device_is_compatible(np, "fsl,t1040-esdhc"))
+	    of_device_is_compatible(np, "fsl,t1040-esdhc") ||
+	    of_device_is_compatible(np, "fsl,ls1021a-esdhc"))
 		host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
 
 	if (of_device_is_compatible(np, "fsl,p2020-esdhc")) {
-- 
2.1.0.27.g96db324


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [v2] mmc: sdhci-pltfm: enable interrupt mode to detect card for ls1021a
  2015-09-16  6:36 [v2] mmc: sdhci-pltfm: enable interrupt mode to detect card for ls1021a Yangbo Lu
@ 2015-09-23 21:42 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2015-09-23 21:42 UTC (permalink / raw)
  To: Yangbo Lu; +Cc: linux-mmc

On 16 September 2015 at 08:36, Yangbo Lu <yangbo.lu@freescale.com> wrote:
> Enable interrupt mode to detect card instead of polling mode for
> ls1021a by removing the quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION.
> This could improve data transferring performance and avoid the call
> trace caused by polling card status sometime.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
> Changes for v2:
>         - Modified commit message
> ---
>  drivers/mmc/host/sdhci-of-esdhc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 653f335..2a54dbe 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -371,7 +371,8 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
>             of_device_is_compatible(np, "fsl,p5020-esdhc") ||
>             of_device_is_compatible(np, "fsl,p4080-esdhc") ||
>             of_device_is_compatible(np, "fsl,p1020-esdhc") ||
> -           of_device_is_compatible(np, "fsl,t1040-esdhc"))
> +           of_device_is_compatible(np, "fsl,t1040-esdhc") ||
> +           of_device_is_compatible(np, "fsl,ls1021a-esdhc"))
>                 host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
>         if (of_device_is_compatible(np, "fsl,p2020-esdhc")) {
> --
> 2.1.0.27.g96db324
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-23 21:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16  6:36 [v2] mmc: sdhci-pltfm: enable interrupt mode to detect card for ls1021a Yangbo Lu
2015-09-23 21:42 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).