From: Jisheng Zhang <jszhang@marvell.com>
To: ulf.hansson@linaro.org, arnd@arndb.de,
ludovic.desroches@atmel.com, swarren@wwwdotorg.org,
lee@kernel.org, eric@anholt.net, michal.simek@xilinx.com,
soren.brinkmann@xilinx.com, srinivas.kandagatla@gmail.com,
maxime.coquelin@st.com, patrice.chotard@st.com,
thierry.reding@gmail.com, sebastian.hesselbarth@gmail.com
Cc: Jisheng Zhang <jszhang@marvell.com>,
kernel@stlinux.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 05/13] mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove()
Date: Tue, 26 Jan 2016 18:15:45 +0800 [thread overview]
Message-ID: <1453803353-6266-6-git-send-email-jszhang@marvell.com> (raw)
In-Reply-To: <1453803353-6266-1-git-send-email-jszhang@marvell.com>
sdhci_pltfm_unregister() could operate host's registers, it will cause
problems if the clk is already disabled and unprepared. Fix this issue
by moving the clk_disable_unprepare() call to the end of remove
function.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 75379cb..50eb8bc 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -206,13 +206,16 @@ clk_dis_ahb:
static int sdhci_arasan_remove(struct platform_device *pdev)
{
+ int ret;
struct sdhci_host *host = platform_get_drvdata(pdev);
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
struct sdhci_arasan_data *sdhci_arasan = pltfm_host->priv;
+ ret = sdhci_pltfm_unregister(pdev);
+
clk_disable_unprepare(sdhci_arasan->clk_ahb);
- return sdhci_pltfm_unregister(pdev);
+ return ret;
}
static const struct of_device_id sdhci_arasan_of_match[] = {
--
2.7.0
next prev parent reply other threads:[~2016-01-26 10:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 10:15 [PATCH v4 00/13] mmc: use sdhci_pltfm_init for private allocation and clean up Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 01/13] mmc: sdhci-bcm2835: use sdhci_pltfm_init for private allocation Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 02/13] mmc: sdhci-esdhc-imx: " Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 03/13] mmc: sdhci-msm: factorise sdhci_msm_pdata outisde of sdhci_msm_host Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 04/13] mmc: sdhci-msm: use sdhci_pltfm_init for private allocation Jisheng Zhang
2016-01-26 10:15 ` Jisheng Zhang [this message]
2016-01-26 18:30 ` [PATCH v4 05/13] mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove() Sören Brinkmann
2016-01-26 10:15 ` [PATCH v4 06/13] mmc: sdhci-of-arasan: use sdhci_pltfm_init for private allocation Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 08/13] mmc: sdhci-of-esdhc: " Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 09/13] mmc: sdhci-pxav3: " Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 10/13] mmc: sdhci-st: " Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 11/13] mmc: sdhci-tegra: " Jisheng Zhang
2016-01-27 15:14 ` Thierry Reding
2016-01-26 10:15 ` [PATCH v4 12/13] mmc: sdhci-pxav2: remove unnecessary assignment of pltfm_host->priv Jisheng Zhang
2016-01-26 10:15 ` [PATCH v4 13/13] mmc: sdhci-pltfm: remove priv variable from sdhci_pltfm_host Jisheng Zhang
[not found] ` <1453803353-6266-1-git-send-email-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2016-01-26 10:15 ` [PATCH v4 07/13] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation Jisheng Zhang
2016-02-04 10:38 ` [PATCH v4 00/13] mmc: use sdhci_pltfm_init for private allocation and clean up Ulf Hansson
2016-02-08 14:09 ` Adrian Hunter
2016-02-16 2:38 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453803353-6266-6-git-send-email-jszhang@marvell.com \
--to=jszhang@marvell.com \
--cc=arnd@arndb.de \
--cc=eric@anholt.net \
--cc=kernel@stlinux.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=maxime.coquelin@st.com \
--cc=michal.simek@xilinx.com \
--cc=patrice.chotard@st.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soren.brinkmann@xilinx.com \
--cc=srinivas.kandagatla@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).