* [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly
@ 2016-01-26 10:26 Jisheng Zhang
2016-01-27 2:00 ` Scott Branden
2016-02-02 13:11 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Jisheng Zhang @ 2016-01-26 10:26 UTC (permalink / raw)
To: ulf.hansson, rjui, sbranden, jonmason
Cc: linux-mmc, linux-arm-kernel, bcm-kernel-feedback-list,
linux-kernel, Jisheng Zhang
The sdhci_iproc_remove() is jsut a wrapper to sdhci_pltfm_unregister.
So use the sdhci_pltfm_unregister() for the .remove hook directly.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/mmc/host/sdhci-iproc.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 3b423b0..24c5546 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -220,11 +220,6 @@ err:
return ret;
}
-static int sdhci_iproc_remove(struct platform_device *pdev)
-{
- return sdhci_pltfm_unregister(pdev);
-}
-
static struct platform_driver sdhci_iproc_driver = {
.driver = {
.name = "sdhci-iproc",
@@ -232,7 +227,7 @@ static struct platform_driver sdhci_iproc_driver = {
.pm = SDHCI_PLTFM_PMOPS,
},
.probe = sdhci_iproc_probe,
- .remove = sdhci_iproc_remove,
+ .remove = sdhci_pltfm_unregister,
};
module_platform_driver(sdhci_iproc_driver);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly
2016-01-26 10:26 [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly Jisheng Zhang
@ 2016-01-27 2:00 ` Scott Branden
2016-02-02 13:11 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Scott Branden @ 2016-01-27 2:00 UTC (permalink / raw)
To: Jisheng Zhang, ulf.hansson, rjui, jonmason
Cc: linux-mmc, linux-arm-kernel, bcm-kernel-feedback-list,
linux-kernel
Hi Jisheng,
Looks good.
Acked-by: Scott Branden <sbranden@broadcom.com>
On 16-01-26 02:26 AM, Jisheng Zhang wrote:
> The sdhci_iproc_remove() is jsut a wrapper to sdhci_pltfm_unregister.
> So use the sdhci_pltfm_unregister() for the .remove hook directly.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/mmc/host/sdhci-iproc.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 3b423b0..24c5546 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -220,11 +220,6 @@ err:
> return ret;
> }
>
> -static int sdhci_iproc_remove(struct platform_device *pdev)
> -{
> - return sdhci_pltfm_unregister(pdev);
> -}
> -
> static struct platform_driver sdhci_iproc_driver = {
> .driver = {
> .name = "sdhci-iproc",
> @@ -232,7 +227,7 @@ static struct platform_driver sdhci_iproc_driver = {
> .pm = SDHCI_PLTFM_PMOPS,
> },
> .probe = sdhci_iproc_probe,
> - .remove = sdhci_iproc_remove,
> + .remove = sdhci_pltfm_unregister,
> };
> module_platform_driver(sdhci_iproc_driver);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly
2016-01-26 10:26 [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly Jisheng Zhang
2016-01-27 2:00 ` Scott Branden
@ 2016-02-02 13:11 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2016-02-02 13:11 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Ray Jui, Scott Branden, Jon Mason, linux-mmc,
linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list,
linux-kernel@vger.kernel.org
On 26 January 2016 at 11:26, Jisheng Zhang <jszhang@marvell.com> wrote:
> The sdhci_iproc_remove() is jsut a wrapper to sdhci_pltfm_unregister.
> So use the sdhci_pltfm_unregister() for the .remove hook directly.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 3b423b0..24c5546 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -220,11 +220,6 @@ err:
> return ret;
> }
>
> -static int sdhci_iproc_remove(struct platform_device *pdev)
> -{
> - return sdhci_pltfm_unregister(pdev);
> -}
> -
> static struct platform_driver sdhci_iproc_driver = {
> .driver = {
> .name = "sdhci-iproc",
> @@ -232,7 +227,7 @@ static struct platform_driver sdhci_iproc_driver = {
> .pm = SDHCI_PLTFM_PMOPS,
> },
> .probe = sdhci_iproc_probe,
> - .remove = sdhci_iproc_remove,
> + .remove = sdhci_pltfm_unregister,
> };
> module_platform_driver(sdhci_iproc_driver);
>
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-02 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-26 10:26 [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly Jisheng Zhang
2016-01-27 2:00 ` Scott Branden
2016-02-02 13:11 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).