* [PATCH] mmc: of_mmc_spi: fix unused warning
@ 2016-03-07 23:36 Brian Norris
2016-03-16 11:38 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2016-03-07 23:36 UTC (permalink / raw)
To: linux-mmc; +Cc: Ulf Hansson, Brian Norris
drivers/mmc/host/of_mmc_spi.c: In function 'mmc_spi_get_pdata':
drivers/mmc/host/of_mmc_spi.c:77:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
int ret = -EINVAL;
^
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
Compile tested only
drivers/mmc/host/of_mmc_spi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index 660170cd04d9..85bbebfde02e 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -74,7 +74,6 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
const u32 *voltage_ranges;
int num_ranges;
int i;
- int ret = -EINVAL;
if (dev->platform_data || !np)
return dev->platform_data;
@@ -97,7 +96,6 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
mask = mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]),
be32_to_cpu(voltage_ranges[j + 1]));
if (!mask) {
- ret = -EINVAL;
dev_err(dev, "OF: voltage-range #%d is invalid\n", i);
goto err_ocr;
}
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: of_mmc_spi: fix unused warning
2016-03-07 23:36 [PATCH] mmc: of_mmc_spi: fix unused warning Brian Norris
@ 2016-03-16 11:38 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2016-03-16 11:38 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mmc
On 8 March 2016 at 00:36, Brian Norris <computersforpeace@gmail.com> wrote:
> drivers/mmc/host/of_mmc_spi.c: In function 'mmc_spi_get_pdata':
> drivers/mmc/host/of_mmc_spi.c:77:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
> int ret = -EINVAL;
> ^
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> Compile tested only
>
> drivers/mmc/host/of_mmc_spi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index 660170cd04d9..85bbebfde02e 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -74,7 +74,6 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
> const u32 *voltage_ranges;
> int num_ranges;
> int i;
> - int ret = -EINVAL;
>
> if (dev->platform_data || !np)
> return dev->platform_data;
> @@ -97,7 +96,6 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
> mask = mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]),
> be32_to_cpu(voltage_ranges[j + 1]));
> if (!mask) {
> - ret = -EINVAL;
> dev_err(dev, "OF: voltage-range #%d is invalid\n", i);
> goto err_ocr;
> }
> --
> 2.7.0.rc3.207.g0ac5344
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-16 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-07 23:36 [PATCH] mmc: of_mmc_spi: fix unused warning Brian Norris
2016-03-16 11:38 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox